Skip to content

golang: Update to 1.18 from 1.18rc1#108870

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
dims:golang-update-to-1.18-from1.18rc1
Mar 22, 2022
Merged

golang: Update to 1.18 from 1.18rc1#108870
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
dims:golang-update-to-1.18-from1.18rc1

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Mar 22, 2022 •
edited by wojtek-t
Loading

Signed-off-by: Davanum Srinivas [email protected]

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

We cannot ship rc1 ... code freeze is a week away. Let's switch to the 1.18 final release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes 1.24 bumped version of golang it is compiled with to go1.18, which introduced significant changes to its garbage collection algorithm. As a result, we observed an increase in memory usage for kube-apiserver in larger an heavily loaded clusters up to ~25% (with the benefit of API call latencies drop by up to 10x on 99th percentiles). If the memory increase is not acceptable for you you can mitigate by setting GOGC env variable (for our tests using GOGC=63 brings memory usage back to original value, although the exact value may depend on usage patterns on your cluster).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2022
@dims
Copy link
Copy Markdown
Member Author

dims commented Mar 22, 2022

/assign @justaugustus @saschagrunert

follow up from #107105 which updated k/k to rc1 and related to kubernetes/release#2307

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2022
@dims
Copy link
Copy Markdown
Member Author

dims commented Mar 22, 2022

/sig testing
/sig architecture
/sig release

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@cpanato
Copy link
Copy Markdown
Member

cpanato commented Mar 22, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2022
@cpanato cpanato mentioned this pull request Mar 22, 2022
Closed
45 tasks
@dims dims force-pushed the golang-update-to-1.18-from1.18rc1 branch 2 times, most recently from 3b724a1 to 6d5ade4 Compare March 22, 2022 13:09
cpanato
cpanato reviewed Mar 22, 2022
View reviewed changes
Comment thread hack/lib/golang.sh Outdated
@dims dims force-pushed the golang-update-to-1.18-from1.18rc1 branch from 6d5ade4 to 450ec9a Compare March 22, 2022 13:35
@dims
golang: Update to 1.18 from 1.18rc1
d8f1da5 
Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the golang-update-to-1.18-from1.18rc1 branch from 450ec9a to d8f1da5 Compare March 22, 2022 13:47
@dims
Copy link
Copy Markdown
Member Author

dims commented Mar 22, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel

@dims
Copy link
Copy Markdown
Member Author

dims commented Mar 22, 2022

/retest

cpanato
cpanato approved these changes Mar 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5984099 into kubernetes:master Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 22, 2022
@cpanato cpanato mentioned this pull request Mar 22, 2022
Merged
This was referenced Mar 23, 2022
Closed
Closed
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Mar 23, 2022

@dims - I updated the release note in this PR according to the discussion in #108357

I'm resolving the corresponding bug based on that.

@liggitt - FYI

@wojtek-t wojtek-t mentioned this pull request Mar 23, 2022
Closed
4 tasks
@dims
Copy link
Copy Markdown
Member Author

dims commented Mar 23, 2022

Thanks @wojtek-t

@KnVerey KnVerey mentioned this pull request Mar 23, 2022
Closed
@justaugustus justaugustus mentioned this pull request Apr 4, 2022
Merged
@chaochn47 chaochn47 mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

6 participants

@dims @cpanato @k8s-ci-robot @wojtek-t @justaugustus @saschagrunert