Skip to content

golang: Update to go1.18rc1#107105

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
justaugustus:go118
Feb 21, 2022
Merged

golang: Update to go1.18rc1#107105
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
justaugustus:go118

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Dec 17, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Part of kubernetes/release#2307.

  • golang: Update to go1.18rc1
  • [go1.18] Bump golang.org/x/... dependencies
  • generated: Run hack/lint-dependencies.sh and hack/update-vendor.sh

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes in now built with go1.18rc1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2021
@justaugustus justaugustus mentioned this pull request Dec 17, 2021
Closed
45 tasks
@justaugustus justaugustus mentioned this pull request Dec 17, 2021
Open
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 17, 2021

/test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 17, 2021

@justaugustus: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-conformance-kind-ga-only-parallel
  • /test pull-kubernetes-dependencies
  • /test pull-kubernetes-dependencies-go-canary
  • /test pull-kubernetes-e2e-gce
  • /test pull-kubernetes-e2e-gce-100-performance
  • /test pull-kubernetes-e2e-gce-big-performance
  • /test pull-kubernetes-e2e-gce-canary
  • /test pull-kubernetes-e2e-gce-large-performance
  • /test pull-kubernetes-e2e-gce-network-proxy-http-connect
  • /test pull-kubernetes-e2e-gce-no-stage
  • /test pull-kubernetes-e2e-gce-ubuntu
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
  • /test pull-kubernetes-e2e-kind
  • /test pull-kubernetes-e2e-kind-ipv6
  • /test pull-kubernetes-files-remake
  • /test pull-kubernetes-integration
  • /test pull-kubernetes-integration-go-canary
  • /test pull-kubernetes-kubemark-e2e-gce-scale
  • /test pull-kubernetes-node-e2e-containerd
  • /test pull-kubernetes-typecheck
  • /test pull-kubernetes-unit
  • /test pull-kubernetes-unit-go-canary
  • /test pull-kubernetes-verify
  • /test pull-kubernetes-verify-go-canary
  • /test pull-kubernetes-verify-govet-levee

The following commands are available to trigger optional jobs:

  • /test check-dependency-stats
  • /test pull-kubernetes-conformance-image-test
  • /test pull-kubernetes-conformance-kind-ga-only
  • /test pull-kubernetes-conformance-kind-ipv6-parallel
  • /test pull-kubernetes-cross
  • /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd
  • /test pull-kubernetes-e2e-aks-engine-azure-file-windows-containerd
  • /test pull-kubernetes-e2e-aks-engine-gpu-windows-dockershim
  • /test pull-kubernetes-e2e-aks-engine-windows-containerd
  • /test pull-kubernetes-e2e-capz-azure-disk
  • /test pull-kubernetes-e2e-capz-azure-disk-vmss
  • /test pull-kubernetes-e2e-capz-azure-file
  • /test pull-kubernetes-e2e-capz-azure-file-vmss
  • /test pull-kubernetes-e2e-capz-conformance
  • /test pull-kubernetes-e2e-capz-ha-control-plane
  • /test pull-kubernetes-e2e-containerd-gce
  • /test pull-kubernetes-e2e-gce-alpha-features
  • /test pull-kubernetes-e2e-gce-correctness
  • /test pull-kubernetes-e2e-gce-csi-serial
  • /test pull-kubernetes-e2e-gce-device-plugin-gpu
  • /test pull-kubernetes-e2e-gce-iscsi
  • /test pull-kubernetes-e2e-gce-iscsi-serial
  • /test pull-kubernetes-e2e-gce-kubetest2
  • /test pull-kubernetes-e2e-gce-network-proxy-grpc
  • /test pull-kubernetes-e2e-gce-storage-disruptive
  • /test pull-kubernetes-e2e-gce-storage-slow
  • /test pull-kubernetes-e2e-gce-storage-snapshot
  • /test pull-kubernetes-e2e-gci-gce-autoscaling
  • /test pull-kubernetes-e2e-gci-gce-ingress
  • /test pull-kubernetes-e2e-gci-gce-ipvs
  • /test pull-kubernetes-e2e-iptables-azure-dualstack
  • /test pull-kubernetes-e2e-ipvs-azure-dualstack
  • /test pull-kubernetes-e2e-kind-canary
  • /test pull-kubernetes-e2e-kind-dual-canary
  • /test pull-kubernetes-e2e-kind-ipv6-canary
  • /test pull-kubernetes-e2e-kind-ipvs-dual-canary
  • /test pull-kubernetes-e2e-kind-multizone
  • /test pull-kubernetes-e2e-kops-aws
  • /test pull-kubernetes-e2e-ubuntu-gce-network-policies
  • /test pull-kubernetes-e2e-windows-gce
  • /test pull-kubernetes-kubemark-e2e-gce-big
  • /test pull-kubernetes-local-e2e
  • /test pull-kubernetes-node-crio-cgrpv2-e2e
  • /test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2
  • /test pull-kubernetes-node-crio-e2e
  • /test pull-kubernetes-node-crio-e2e-kubetest2
  • /test pull-kubernetes-node-e2e
  • /test pull-kubernetes-node-e2e-alpha
  • /test pull-kubernetes-node-e2e-alpha-kubetest2
  • /test pull-kubernetes-node-e2e-containerd-features
  • /test pull-kubernetes-node-e2e-containerd-features-kubetest2
  • /test pull-kubernetes-node-e2e-containerd-kubetest2
  • /test pull-kubernetes-node-e2e-kubetest2
  • /test pull-kubernetes-node-e2e-podutil
  • /test pull-kubernetes-node-kubelet-eviction
  • /test pull-kubernetes-node-kubelet-eviction-kubetest2
  • /test pull-kubernetes-node-kubelet-serial
  • /test pull-kubernetes-node-kubelet-serial-containerd
  • /test pull-kubernetes-node-kubelet-serial-containerd-kubetest2
  • /test pull-kubernetes-node-kubelet-serial-cpu-manager
  • /test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2
  • /test pull-kubernetes-node-kubelet-serial-crio-cgroupv1
  • /test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
  • /test pull-kubernetes-node-kubelet-serial-dockershim
  • /test pull-kubernetes-node-kubelet-serial-hugepages
  • /test pull-kubernetes-node-kubelet-serial-kubetest2
  • /test pull-kubernetes-node-kubelet-serial-memory-manager
  • /test pull-kubernetes-node-kubelet-serial-topology-manager
  • /test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2
  • /test pull-kubernetes-node-memoryqos-cgrpv2
  • /test pull-kubernetes-node-swap-fedora
  • /test pull-kubernetes-node-swap-ubuntu
  • /test pull-kubernetes-unit-experimental
  • /test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubernetes-conformance-kind-ga-only-parallel
  • pull-kubernetes-conformance-kind-ipv6-parallel
  • pull-kubernetes-dependencies
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-e2e-gce-ubuntu-containerd
  • pull-kubernetes-e2e-kind
  • pull-kubernetes-e2e-kind-ipv6
  • pull-kubernetes-integration
  • pull-kubernetes-node-e2e-containerd
  • pull-kubernetes-typecheck
  • pull-kubernetes-unit
  • pull-kubernetes-verify
  • pull-kubernetes-verify-govet-levee
  • pull-publishing-bot-validate
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Dec 17, 2021
Merged
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 17, 2021

For Golang pre-releases, the go-canary variant for kubekins/krte needs to be built ahead of the master variant to enable testing go canary presubmits.
PR for that is here: kubernetes/test-infra#24704

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 17, 2021

/test pull-kubernetes-dependencies-go-canary
/test pull-kubernetes-integration-go-canary
/test pull-kubernetes-unit-go-canary
/test pull-kubernetes-verify-go-canary

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022

@aojea: cat image

Details

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

/retest-required

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

/skip

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

/override pull-kubernetes-integration-go-canary
/override pull-kubernetes-verify-go-canary

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022

@justaugustus: Overrode contexts on behalf of justaugustus: pull-kubernetes-integration-go-canary, pull-kubernetes-verify-go-canary

Details

In response to this:

/override pull-kubernetes-integration-go-canary
/override pull-kubernetes-verify-go-canary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

/override pull-kubernetes-integration-go-canary

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022

@justaugustus: Overrode contexts on behalf of justaugustus: pull-kubernetes-integration-go-canary

Details

In response to this:

/override pull-kubernetes-integration-go-canary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022 •
edited
Loading

@justaugustus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-aks-engine-windows-containerd ebfe82adb073cc778556ed5cf74e30640b951e58 link false /test pull-kubernetes-e2e-aks-engine-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

???
/override pull-kubernetes-verify-go-canary

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022

@justaugustus: Overrode contexts on behalf of justaugustus: pull-kubernetes-verify-go-canary

Details

In response to this:

???
/override pull-kubernetes-verify-go-canary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Copy Markdown
Member

aojea commented Feb 21, 2022

??? /override pull-kubernetes-verify-go-canary

the error are lint failures and thing related to dependencies between modules ... related to golang toolchain for sure

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 21, 2022

??? /override pull-kubernetes-verify-go-canary

the error are lint failures and thing related to dependencies between modules ... related to golang toolchain for sure

Will take anything remaining as follow-ups!

Agreed. The confusion was about the test override not sticking. The default presubmits are not on go1.18 yet, so this won't block other PRs, but the fact that the context is not required, yet blocking the PR from the merge pool is odd.

(Possibly because the jobs were in progress before I overrode them.)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bda996e into kubernetes:master Feb 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 21, 2022
@justaugustus justaugustus mentioned this pull request Feb 21, 2022
Closed
This was referenced Feb 22, 2022
Closed
Closed
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Feb 24, 2022

It seems that this PR has visibly increase memory usage of at least kube-apiserver (10% on 10th-percentile, even more on higher percentiles):
https://perf-dash.k8s.io/#/?jobname=gce-5000Nodes&metriccategoryname=E2E&metricname=LoadResources&PodName=kube-apiserver-gce-scale-cluster-master%2Fkube-apiserver&Resource=memory

We should understand to what extent this is expected and can we somehow mitigate this.

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Feb 24, 2022

@liggitt @kubernetes/sig-scalability @marseel @mborsz ^^

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Feb 24, 2022

OTOH - it's interesting to see how much it helps pod startup time:
https://perf-dash.k8s.io/#/?jobname=gce-5000Nodes&metriccategoryname=E2E&metricname=LoadPodStartup&Metric=pod_startup

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Feb 24, 2022

@wojtek-t can we file an issue to golang so they're aware as we investigate? do we have any pprof info to help narrow down where the memory increase is?

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Feb 24, 2022 •
edited
Loading

We're following up with golang team about that. @tosi3k is looking into it and started the conversation with golang folks.

@dims
Copy link
Copy Markdown
Member

dims commented Feb 25, 2022

@liggitt @wojtek-t do we want to open a blocker issue in k/k for tracking the problem above?

@justaugustus justaugustus mentioned this pull request Feb 25, 2022
Closed
4 tasks
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Feb 25, 2022

@liggitt @wojtek-t do we want to open a blocker issue in k/k for tracking the problem above?

Opened here: #108357
Folks, please keep @kubernetes/release-engineering looped in on the various upstream issues that may crop up :)

@dims dims mentioned this pull request Mar 22, 2022
Merged
@liggitt liggitt mentioned this pull request Nov 17, 2022
Closed
4 tasks
@liggitt liggitt mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@liggitt liggitt

@puerco puerco

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Auth
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.