Update pods validation based on uniqueness of controller #106097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
sig/auth
|
/assign @enj |
liggitt
added
priority/important-soon
k8s-ci-robot
removed
needs-triage
|
/lgtm |
k8s-ci-robot
added
the
lgtm
liggitt
deleted the
feature/pod-security/unique-controller-pods-validation
branch
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #104420 from @akshitgrover (keeping author attribution), adding unit tests and addressing review comments
original description from #104420 follows:
Signed-off-by: Akshit Grover [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates namespaced pod evaluation logic of PodSecurity controller to prioritize evaluation of pods based on uniqueness of the controller that pod belongs to
Which issue(s) this PR fixes:
Fixes #103304
Special notes for your reviewer:
We might need to add some unit tests to validate this scenario but before that I'll need some inputs on the clean way of adding one as it's not straightforward to add a unit test for this scenario, Or if there are any other types of test category we should use
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: