[PodSecurity] Implement metricRecorder for admission #104217

jyz0309 · 2021-08-07T17:13:31Z

Signed-off-by: jyz0309 [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

#103207

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

k8s-ci-robot · 2021-08-07T17:13:39Z

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jyz0309 · 2021-08-08T11:41:57Z

/assign @tallclair PTAL~ I don't know if my implementation meets your requirements🙈

dashpole · 2021-08-12T16:38:30Z

/assign @logicalhan @CatherineF-dev

k8s-ci-robot · 2021-08-12T16:38:32Z

@dashpole: GitHub didn't allow me to assign the following users: CatherineF-dev.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @logicalhan @CatherineF-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dashpole · 2021-08-12T16:38:56Z

/ok-to-test
/triage accepted

jyz0309 · 2021-10-12T08:21:51Z

I don't know why verify-import test failed... Just need some help for this test.😳

s-urbaniak · 2021-10-13T14:29:50Z

@jyz0309 you'll most likely have to add these imports to

kubernetes/staging/publishing/import-restrictions.yaml

Lines 271 to 283 in f0e80a6

    
           - baseImportPath: "./vendor/k8s.io/pod-security-admission/" 
        
             allowedImports: 
        
             - k8s.io/api 
        
             - k8s.io/apimachinery 
        
             - k8s.io/apiserver/pkg/admission 
        
             - k8s.io/apiserver/pkg/server 
        
             - k8s.io/client-go 
        
             - k8s.io/klog 
        
             - k8s.io/pod-security-admission 
        
             - k8s.io/component-base/featuregate 
        
             - k8s.io/component-base/logs 
        
             - k8s.io/component-base/cli 
        
             - k8s.io/utils

jyz0309 · 2021-10-14T04:11:09Z

/assign @deads2k @nikhita

jyz0309 · 2021-10-14T11:09:24Z

@jyz0309 you'll most likely have to add these imports to

kubernetes/staging/publishing/import-restrictions.yaml

Lines 271 to 283 in f0e80a6

- baseImportPath: "./vendor/k8s.io/pod-security-admission/"

allowedImports:

- k8s.io/api

- k8s.io/apimachinery

- k8s.io/apiserver/pkg/admission

- k8s.io/apiserver/pkg/server

- k8s.io/client-go

- k8s.io/klog

- k8s.io/pod-security-admission

- k8s.io/component-base/featuregate

- k8s.io/component-base/logs

- k8s.io/component-base/cli

- k8s.io/utils

Thanks!

staging/src/k8s.io/pod-security-admission/admission/admission.go

staging/src/k8s.io/pod-security-admission/admission/admission_test.go

tallclair

Almost there!

staging/src/k8s.io/pod-security-admission/admission/admission.go

Signed-off-by: jyz0309 <[email protected]> use init to register metric Signed-off-by: jyz0309 <[email protected]> fix test Signed-off-by: jyz0309 <[email protected]> remove check Signed-off-by: jyz0309 <[email protected]> remove blank line Signed-off-by: jyz0309 <[email protected]> add allowedImports Signed-off-by: jyz0309 <[email protected]> Add mock recorder Signed-off-by: jyz0309 <[email protected]> format code Signed-off-by: jyz0309 <[email protected]> separe record into 3 function Signed-off-by: jyz0309 <[email protected]>

Signed-off-by: jyz0309 <[email protected]>

jyz0309 · 2021-10-19T06:31:06Z

/retest-required

tallclair

/lgtm
/approve

Thanks!

I'll take the follow up, to add the other 2 metrics & unit tests.

jyz0309 · 2021-10-20T02:32:56Z

/lgtm /approve

Thanks!

I'll take the follow up, to add the other 2 metrics & unit tests.

Oh, maybe I can help add other 2 metrics, I don't add it in this PR just because I don't want to make this PR too complex to review🤣

jyz0309 · 2021-10-20T03:13:03Z

It seems that this PR still need your approve to merge. Can you help me merge it? @tallclair Thanks a lot!

liggitt · 2021-10-21T02:00:56Z

/approve

k8s-ci-robot · 2021-10-21T02:01:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~plugin/pkg/admission/OWNERS~~ [liggitt]
~~staging/publishing/OWNERS~~ [liggitt]
~~staging/src/k8s.io/pod-security-admission/OWNERS~~ [liggitt,tallclair]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from adtac and liggitt August 7, 2021 17:14

jyz0309 force-pushed the metric branch from 6e21467 to b4221be Compare August 7, 2021 17:17

jyz0309 changed the title ~~[WIP] Implement metricRecorder for admission~~ Implement metricRecorder for admission Aug 8, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2021

jyz0309 changed the title ~~Implement metricRecorder for admission~~ [PodSecurity] Implement metricRecorder for admission Aug 8, 2021

tallclair self-assigned this Aug 8, 2021

k8s-ci-robot assigned logicalhan Aug 12, 2021

k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 14, 2021

k8s-ci-robot assigned deads2k and nikhita Oct 14, 2021

tallclair reviewed Oct 14, 2021

View reviewed changes

jyz0309 requested a review from tallclair October 17, 2021 13:07

tallclair mentioned this pull request Oct 18, 2021

Add --version flag to podsecurity-webhook command #105749

Merged

tallclair reviewed Oct 18, 2021

View reviewed changes

staging/src/k8s.io/pod-security-admission/admission/admission.go Outdated Show resolved Hide resolved

staging/src/k8s.io/pod-security-admission/admission/admission.go Outdated Show resolved Hide resolved

jyz0309 added 2 commits October 19, 2021 13:15

fix comment

33fe0df

Signed-off-by: jyz0309 <[email protected]>

jyz0309 force-pushed the metric branch from 5c813d1 to 33fe0df Compare October 19, 2021 05:15

jyz0309 requested a review from tallclair October 19, 2021 05:16

tallclair reviewed Oct 19, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2021

tallclair added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 19, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021

k8s-ci-robot merged commit ae9ca48 into kubernetes:master Oct 21, 2021

k8s-ci-robot added this to the v1.23 milestone Oct 21, 2021

liggitt mentioned this pull request Nov 3, 2021

PodSecurity admission (PodSecurityPolicy replacement) kubernetes/enhancements#2579

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PodSecurity] Implement metricRecorder for admission #104217

[PodSecurity] Implement metricRecorder for admission #104217

jyz0309 commented Aug 7, 2021 •

edited by tallclair

Loading

k8s-ci-robot commented Aug 7, 2021

jyz0309 commented Aug 8, 2021

dashpole commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

dashpole commented Aug 12, 2021

jyz0309 commented Oct 12, 2021

s-urbaniak commented Oct 13, 2021

jyz0309 commented Oct 14, 2021

jyz0309 commented Oct 14, 2021

tallclair left a comment

jyz0309 commented Oct 19, 2021

tallclair left a comment

jyz0309 commented Oct 20, 2021

jyz0309 commented Oct 20, 2021 •

edited

Loading

liggitt commented Oct 21, 2021

k8s-ci-robot commented Oct 21, 2021

[PodSecurity] Implement metricRecorder for admission #104217

[PodSecurity] Implement metricRecorder for admission #104217

Conversation

jyz0309 commented Aug 7, 2021 • edited by tallclair Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Aug 7, 2021

jyz0309 commented Aug 8, 2021

dashpole commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

dashpole commented Aug 12, 2021

jyz0309 commented Oct 12, 2021

s-urbaniak commented Oct 13, 2021

jyz0309 commented Oct 14, 2021

jyz0309 commented Oct 14, 2021

tallclair left a comment

Choose a reason for hiding this comment

jyz0309 commented Oct 19, 2021

tallclair left a comment

Choose a reason for hiding this comment

jyz0309 commented Oct 20, 2021

jyz0309 commented Oct 20, 2021 • edited Loading

liggitt commented Oct 21, 2021

k8s-ci-robot commented Oct 21, 2021

jyz0309 commented Aug 7, 2021 •

edited by tallclair

Loading

jyz0309 commented Oct 20, 2021 •

edited

Loading