Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check drop capabilities.go #103543

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Implement check drop capabilities.go #103543

merged 4 commits into from
Jul 7, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 7, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #103469, last three commits are new

Which issue(s) this PR fixes:

Fixes #103271

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/cc @tallclair @sejr @mgutierrez98

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot requested a review from tallclair July 7, 2021 14:54
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: sejr, mgutierrez98.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #103469, last three commits are new

Which issue(s) this PR fixes:

Fixes #103271

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/cc @tallclair @sejr @mgutierrez98

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jul 7, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

/sig auth
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@liggitt liggitt added this to the v1.22 milestone Jul 7, 2021
@liggitt liggitt mentioned this pull request Jul 7, 2021
Closed
@tallclair
Copy link
Member

Verify needs a cleanup. Otherwise,
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@liggitt liggitt force-pushed the implement-check_dropCapabilities.go branch from c7d8fd5 to 6408f3d Compare July 7, 2021 16:02
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

fixed boilerplate (https://github.com/kubernetes/kubernetes/compare/c7d8fd5100a0be917412e6b24a4c04738da77347..6408f3dffc0e0ed138af349a2805c03cf36102ec)

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

/retest

integration timeout

@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

timeout again

/retest

@sejr
Copy link
Contributor

sejr commented Jul 7, 2021

/retest

@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

integration flake is really bad, tracked in #103512

@liggitt
Copy link
Member Author

liggitt commented Jul 7, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit a392ca0 into kubernetes:master Jul 7, 2021
@liggitt liggitt deleted the implement-check_dropCapabilities.go branch July 7, 2021 21:29
@liggitt liggitt mentioned this pull request Jul 10, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

[PodSecurity] restricted capabilities
5 participants
@liggitt @k8s-ci-robot @tallclair @sejr @mgutierrez98