[1.21] vendor: bump runc to 1.0.0 by kolyshkin · Pull Request #103392 · kubernetes/kubernetes

kolyshkin · 2021-07-01T02:08:53Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Bumping runc dependency to 1.0.0, fixing a few issues.

This is a backport of #102508 to release-1.21 branch.

Which issue(s) this PR fixes:

Fixes: #102676

Special notes for your reviewer:

I am not backporting the second commit from PR #102508 as it's not important (a cleanup).

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

n/a

k8s-ci-robot · 2021-07-01T02:08:56Z

@kolyshkin: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-07-01T02:09:01Z

@kolyshkin: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-07-01T02:09:02Z

Hi @kolyshkin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-07-01T02:09:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kolyshkin
To complete the pull request process, please assign liggitt after the PR has been reviewed.
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS
staging/src/k8s.io/api/OWNERS
staging/src/k8s.io/legacy-cloud-providers/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liggitt · 2021-07-01T03:10:14Z

the new version of proto libraries brought deprecations with them (see https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103392/pull-kubernetes-verify/1410422073385291776)

see fix in master in ff2c614

liggitt · 2021-07-01T03:10:30Z

lgtm once CI is clean

liggitt · 2021-07-01T03:10:58Z

is there a CI job demonstrating #102676 we can see turn green with this?

tao12345666333 · 2021-07-01T04:25:20Z

/test pull-kubernetes-verify

kolyshkin · 2021-07-01T16:12:29Z

is there a CI job demonstrating #102676 we can see turn green with this?

Alas I don't know how to reproduce this. It should happen when kubelet decides to create a pod cgroup twice (IOW create a pod cgroup which already exists), but I don't know kubernetes enough to pinpoint in which exact scenario it's doing this (it might be something like create two containers in a pod, remove one, then create one -- but I'm not sure). There may be no test case that does exactly that.

It was a clear regression in runc and a clear fix, so I'm 99% sure it fixes the issue #102676.

fedebongio · 2021-07-01T20:13:07Z

/remove-sig api-machinery

(cherry picked from commit ff2c614) [kolyshkin: run ./hack/update-vendor.sh] Signed-off-by: Kir Kolyshkin <[email protected]>

Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin · 2021-07-02T20:31:31Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

0dae379 Switch to non-deprecated timestamppb.Now()

Fixed.

k8s-ci-robot · 2021-07-02T21:34:18Z

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd	`289372d`	link	`/test pull-kubernetes-e2e-gce-ubuntu-containerd`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

liggitt · 2021-07-03T16:34:56Z

/hold

until #102508 (comment) kubernetes/kops#11911 is understood so we know we're not backporting a worse regression than the one this is fixing

caesarxuchao · 2021-07-08T20:05:46Z

/remove-sig api-machinery

odinuge · 2021-07-14T19:20:50Z

Upstream PR was reverted in #103483. This should not be cherry-picked since it introduces an even worse regression..

/close

k8s-ci-robot · 2021-07-14T19:20:57Z

@odinuge: Closed this PR.

Details

In response to this:

Upstream PR was reverted in #103483. This should not be cherry-picked since it introduces an even worse regression..

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added this to the v1.21 milestone Jul 1, 2021

k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jul 1, 2021

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 1, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Jul 1, 2021

k8s-ci-robot added area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 1, 2021

k8s-ci-robot requested review from a team, andrewsykim and bowei July 1, 2021 02:09

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2021

liggitt reviewed Jul 1, 2021

View reviewed changes

Comment thread go.mod Outdated

kolyshkin force-pushed the 1.21-runc-1.0 branch from 57a74c6 to 16213e6 Compare July 1, 2021 15:55

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 1, 2021

kolyshkin force-pushed the 1.21-runc-1.0 branch from 16213e6 to ce276b2 Compare July 1, 2021 16:19

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 1, 2021

kolyshkin force-pushed the 1.21-runc-1.0 branch from ce276b2 to 34972b9 Compare July 1, 2021 18:27

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 1, 2021

liggitt and others added 2 commits July 2, 2021 13:30

Switch to non-deprecated timestamppb.Now()

8019731

(cherry picked from commit ff2c614) [kolyshkin: run ./hack/update-vendor.sh] Signed-off-by: Kir Kolyshkin <[email protected]>

vendor: bump runc to 1.0.0

289372d

Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin force-pushed the 1.21-runc-1.0 branch from 34972b9 to 289372d Compare July 2, 2021 20:32

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 2, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2021

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 8, 2021

k8s-ci-robot closed this Jul 14, 2021

kolyshkin mentioned this pull request Jul 16, 2021

[1.21] vendor: bump runc to 1.0.1 #103746

Closed

Conversation

kolyshkin commented Jul 1, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jul 1, 2021

Uh oh!

k8s-ci-robot commented Jul 1, 2021

Uh oh!

k8s-ci-robot commented Jul 1, 2021

Uh oh!

k8s-ci-robot commented Jul 1, 2021

Uh oh!

Uh oh!

liggitt commented Jul 1, 2021

Uh oh!

liggitt commented Jul 1, 2021

Uh oh!

liggitt commented Jul 1, 2021

Uh oh!

tao12345666333 commented Jul 1, 2021

Uh oh!

kolyshkin commented Jul 1, 2021

Uh oh!

fedebongio commented Jul 1, 2021

Uh oh!

kolyshkin commented Jul 2, 2021

Uh oh!

k8s-ci-robot commented Jul 2, 2021

Uh oh!

liggitt commented Jul 3, 2021

Uh oh!

caesarxuchao commented Jul 8, 2021

Uh oh!

odinuge commented Jul 14, 2021

Uh oh!

k8s-ci-robot commented Jul 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants