Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PodSecurity] hostProcess baseline check #103382

Merged
merged 2 commits into from
Jul 2, 2021
Merged

[PodSecurity] hostProcess baseline check #103382

merged 2 commits into from
Jul 2, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 30, 2021 •
edited
Loading

What type of PR is this?

/kind feature

Which issue(s) this PR fixes:

Fixes #103381

Even though hostProcess is alpha, we can still forbid true values in the field in the baseline policy

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/cc @tallclair @marosset
/sig auth windows

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2021
@liggitt liggitt force-pushed the podsecurity-hostprocess branch 3 times, most recently from 62b1cb6 to 596b8e1 Compare July 1, 2021 13:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tallclair
tallclair reviewed Jul 1, 2021
View reviewed changes
staging/src/k8s.io/pod-security-admission/test/fixtures_hostProcess.go
fixtureKey{level: api.LevelBaseline, version: api.MajorMinorVersion(1, 0), check: "hostProcess"},
fixtureData_1_0,
)
// TODO: register another set of fixtures with passing test cases that explicitly set hostProcess=false at pod and container level once hostProcess is GA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we add these tests now? They should pass either way (even if the field is dropped).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests trying to explicitly set hostProcess fields on creation get rejected when the feature is off; discussed with sig-windows and were hard-pressed to think of a way that dropping the data and failing at runtime improved the user experience. discussion at #99576 (comment)

@immuzz
Copy link
Contributor

immuzz commented Jul 1, 2021

cc : @jsturtevant @immuzz

@liggitt liggitt mentioned this pull request Jul 1, 2021
Closed
@liggitt liggitt force-pushed the podsecurity-hostprocess branch from 596b8e1 to ac4bb88 Compare July 1, 2021 19:50
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 1, 2021
@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 2, 2021

/retest

@pacoxu
Copy link
Member

pacoxu commented Jul 2, 2021 •
edited
Loading

/retest
/stats/summary test still flakes.

@k8s-ci-robot k8s-ci-robot merged commit defcc91 into kubernetes:master Jul 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 2, 2021
@liggitt liggitt deleted the podsecurity-hostprocess branch July 6, 2021 16:39
This was referenced Jul 7, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@marosset marosset Awaiting requested review from marosset

Assignees

@marosset marosset

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

[PodSecurity] baseline - hostProcess check
7 participants
@liggitt @k8s-ci-robot @immuzz @fedebongio @tallclair @pacoxu @marosset