[PodSecurity] Implement host ports check #103314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
liggitt
reviewed
Jun 29, 2021
staging/src/k8s.io/pod-security-admission/test/fixtures_hostPorts.go
Outdated
Show resolved
Hide resolved
liggitt
reviewed
Jun 29, 2021
staging/src/k8s.io/pod-security-admission/policy/check_hostPorts.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/pod-security-admission/policy/check_hostPorts.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/pod-security-admission/test/fixtures_hostPorts.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/pod-security-admission/test/fixtures_hostPorts.go
Outdated
Show resolved
Hide resolved
|
thanks for the quick turnaround! |
k8s-ci-robot
added
release-note-none
liggitt
reviewed
Jun 30, 2021
staging/src/k8s.io/pod-security-admission/test/fixtures_hostPorts.go
Outdated
Show resolved
Hide resolved
|
once the test fixtures get trimmed down, looks like this also needs |
PushkarJ
force-pushed
the
psp-hostports
branch
4 times, most recently
from
9d34e59 to
9047048
Compare
Applies to baseline policy. Since host ports is a niche feature, usage of any host ports is forbidden for either app container or init container Refactored two fixtures into one for non-host ports in app container and init container Fixes based on PR feedback - remove no-op if check, - use correct Int32 list for hostPort - remove ensureHostPorts func Removed redundant fixtures as per PR feedback Removed minimal valid pod Updates after gofmt
@liggitt Trimmed the fixtures, ran gofmt, regenerated fixtures, ran tests again (passing), squashed and rebased to single commit. Waiting for CI jobs now to pass |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, PushkarJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Applies to baseline policy. Since host ports is a niche feature, usage of any host ports is forbidden for either app container or init container
Which issue(s) this PR fixes:
Fixes #103199
Special notes for your reviewer:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig auth security