Skip to content

Revert "Merge pull request #101888 from kolyshkin/update-runc-rc94"#102094

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:revert-runc
May 18, 2021
Merged

Revert "Merge pull request #101888 from kolyshkin/update-runc-rc94"#102094
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:revert-runc

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented May 18, 2021

This reverts commit b1b06fe, reversing
changes made to 382a339.

xref #101888 (comment)

NONE

/assign @SergeyKanzhelev @bobbypage
/cc @odinuge
/sig node
/kind regression

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 18, 2021
@k8s-ci-robot k8s-ci-robot requested a review from odinuge May 18, 2021 13:13
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 18, 2021
@liggitt liggitt mentioned this pull request May 18, 2021
Merged
@k8s-ci-robot k8s-ci-robot added area/kubectl area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2021
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 18, 2021

/hold for review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@odinuge
Copy link
Copy Markdown
Member

odinuge commented May 18, 2021

/cc @harche

@k8s-ci-robot k8s-ci-robot requested a review from harche May 18, 2021 13:20
@liggitt liggitt mentioned this pull request May 18, 2021
Merged
@dims
Copy link
Copy Markdown
Member

dims commented May 18, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 18, 2021

pull-kubernetes-e2e-gce-alpha-features failure is expected, the job is misconfigured currently

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 18, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 18, 2021
@harche
Copy link
Copy Markdown
Contributor

harche commented May 18, 2021 •
edited
Loading

Thanks @liggitt, the presubmit job with these changes succeeded, https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/102094/pull-kubernetes-node-crio-e2e/1394642497258393600/

@harche
Copy link
Copy Markdown
Contributor

harche commented May 18, 2021

/cc @kolyshkin @mrunalp

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp May 18, 2021 14:05
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2021

@harche: GitHub didn't allow me to request PR reviews from the following users: kolyshkin.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @kolyshkin @mrunalp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odinuge
Copy link
Copy Markdown
Member

odinuge commented May 18, 2021

Just to seen how experimental cgroup v2 tests go (these might fail, and fails in master, but is not blocking)
/test pull-kubernetes-node-crio-cgrpv2-e2e

@dims
Copy link
Copy Markdown
Member

dims commented May 18, 2021

/skip

@harche
Copy link
Copy Markdown
Contributor

harche commented May 18, 2021

#102092 also because of runc update

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2021

@liggitt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features 4b45d0d link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-node-crio-cgrpv2-e2e 4b45d0d link /test pull-kubernetes-node-crio-cgrpv2-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 18, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1295b2c into kubernetes:master May 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 18, 2021
@BenTheElder BenTheElder mentioned this pull request May 18, 2021
Closed
@harche harche mentioned this pull request May 19, 2021
Closed
@kolyshkin kolyshkin mentioned this pull request May 19, 2021
Merged
@liggitt liggitt deleted the revert-runc branch May 20, 2021 18:56
@aojea aojea mentioned this pull request May 25, 2021
Closed
@odinuge odinuge mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odinuge odinuge Awaiting requested review from odinuge

@harche harche Awaiting requested review from harche

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@dims dims

@bobbypage bobbypage

@odinuge odinuge

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

7 participants

@liggitt @odinuge @dims @k8s-ci-robot @harche @bobbypage @SergeyKanzhelev