Skip to content

skip some UT on mac for dockershim #101013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
May 25, 2021
Merged

skip some UT on mac for dockershim #101013

k8s-ci-robot merged 1 commit into from
May 25, 2021
+39 −14

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Apr 12, 2021

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

make test KUBE_RACE=-race KUBE_TIMEOUT=--timeout=240s WHAT=./pkg/kubelet/dockershim KUBE_COVER=y GOFLAGS=-v

local UT running failed on ./pkg/kubelet/dockershim
Some cases are linux only. When unsupported logic is involved, the test case failed.
It makes me fail to run UT on Mac.

Which issue(s) this PR fixes:

Fixes None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2021
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Apr 12, 2021

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 12, 2021
@pacoxu pacoxu mentioned this pull request Apr 13, 2021
Merged
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Apr 14, 2021

/assign @Dragoncell

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2021

@SergeyKanzhelev: GitHub didn't allow me to assign the following users: dragoncell.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @Dragoncell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dragoncell
Dragoncell reviewed Apr 14, 2021
View reviewed changes
Dragoncell
Dragoncell reviewed Apr 14, 2021
View reviewed changes
@Dragoncell
Copy link
Contributor

Dragoncell commented Apr 14, 2021

/assign @Dragoncell

@pacoxu
Copy link
Member Author

pacoxu commented Apr 23, 2021

@Dragoncell could you take a look again?

@Dragoncell
Copy link
Contributor

Dragoncell commented Apr 27, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 27, 2021

@Dragoncell: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dragoncell
Copy link
Contributor

Dragoncell commented Apr 27, 2021

@Dragoncell could you take a look again?

Thanks for the update. Looks good to me.

@pacoxu
Copy link
Member Author

pacoxu commented Apr 28, 2021

/retest
/assign @dchen1107

ehashman
ehashman reviewed May 21, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@pacoxu
Copy link
Member Author

pacoxu commented May 25, 2021

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit 63014d8 into kubernetes:master May 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 25, 2021
@Dragoncell Dragoncell mentioned this pull request Jun 17, 2021
Closed
6 tasks
@pacoxu pacoxu deleted the mac-ut/skips branch June 23, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krmayankk krmayankk Awaiting requested review from krmayankk

@resouer resouer Awaiting requested review from resouer

3 more reviewers

@ehashman ehashman ehashman left review comments

@Dragoncell Dragoncell Dragoncell left review comments

@mrunalp mrunalp mrunalp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehashman ehashman

@Dragoncell Dragoncell

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

6 participants

@pacoxu @SergeyKanzhelev @k8s-ci-robot @Dragoncell @mrunalp @ehashman