Skip to content

frequently flake ut: exec test should not run in Parallel as feature gate is not locked yet #101006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Apr 14, 2021
Merged

frequently flake ut: exec test should not run in Parallel as feature gate is not locked yet #101006

k8s-ci-robot merged 1 commit into from
Apr 14, 2021
+1 −1

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Apr 12, 2021 •
edited
Loading

What type of PR is this?

/kind flake

What this PR does / why we need it:

TestExecInContainer failed a lot in recent pull-kubernetes-unit.

Which issue(s) this PR fixes:

failed example: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/100612/pull-kubernetes-unit/1381446475732488192

Special notes for your reviewer:

the flake is from #100200 which is merged 1 day ago.

The test case will run in only 6 seconds without t.Parallel().

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2021
@pacoxu pacoxu changed the title exec test should not run in Parallel as feature gate is not locked frequently flake ut: exec test should not run in Parallel as feature gate is not locked yet Apr 12, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Apr 12, 2021

/cc SergeyKanzhelev ehashman

odinuge
odinuge approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

/lgtm
/priority important-soon
/triage accept

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 12, 2021

@odinuge: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

Details

In response to this:

Good catch!

/lgtm
/priority important-soon
/triage accept

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@odinuge
Copy link
Member

odinuge commented Apr 12, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2021
jackfrancis
jackfrancis reviewed Apr 12, 2021
View reviewed changes
@pacoxu pacoxu force-pushed the flake/fix-exec-probe branch from 8a647e3 to 096f0ec Compare April 13, 2021 01:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@yangjunmyfm192085
Copy link
Contributor

yangjunmyfm192085 commented Apr 13, 2021

/test pull-kubernetes-unit

@pacoxu pacoxu force-pushed the flake/fix-exec-probe branch from 096f0ec to 49e7700 Compare April 13, 2021 06:16
@pacoxu
Copy link
Member Author

pacoxu commented Apr 13, 2021 •
edited
Loading

local test results(as I was using mac, I run it with #101013 ):

8m5s: 371 runs so far, 0 failures

@pacoxu pacoxu requested a review from odinuge April 13, 2021 09:00
odinuge
odinuge approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Apr 13, 2021

/assign @derekwaynecarr
for approval

failed 60+/216 today

jackfrancis
jackfrancis approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Apr 14, 2021

@derekwaynecarr would you take a look？

@mrunalp
Copy link
Contributor

mrunalp commented Apr 14, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mrunalp, odinuge, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@pacoxu pacoxu mentioned this pull request Apr 14, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 87e0466 into kubernetes:master Apr 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 14, 2021
This was referenced Apr 14, 2021
Closed
Closed
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 22, 2021
@k8s-ci-robot
Merge pull request #101127 from jackfrancis/automated-cherry-pick-of-…
d906e15 
…#100200-upstream-release-1.21

Automated cherry pick of #100200: respect ExecProbeTimeout and #101006: exec test should not run in Parallel
k8s-ci-robot added a commit that referenced this pull request Apr 22, 2021
@k8s-ci-robot
Merge pull request #101126 from jackfrancis/automated-cherry-pick-of-…
9b8b828 
…#100200-upstream-release-1.20

Automated cherry pick of #100200: respect ExecProbeTimeout and #101006: exec test should not run in Parallel
@pacoxu pacoxu deleted the flake/fix-exec-probe branch June 23, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@yujuhong yujuhong Awaiting requested review from yujuhong

@ehashman ehashman Awaiting requested review from ehashman

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

2 more reviewers

@odinuge odinuge odinuge approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odinuge odinuge

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

7 participants

@pacoxu @k8s-ci-robot @odinuge @yangjunmyfm192085 @mrunalp @jackfrancis @derekwaynecarr