Skip to content

job controller: don't mutate shared cache object #100553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Mar 25, 2021
Merged

job controller: don't mutate shared cache object #100553

k8s-ci-robot merged 2 commits into from
Mar 25, 2021

Conversation

@adtac
Copy link

@adtac adtac commented Mar 25, 2021

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

The Job controller has been mutating the shared cache for a loooong time, but I guess no one noticed this. When I tried to reproduce the failing integration test report #100551 locally, after several hours of very frustrating debugging, I noticed the mutation detector catching this bug. I believe this is also the true root cause of this bug, so to confirm this, I've modified the TestSuspendJob integration test to run all subtests in pre-submit (previously, only the first subtest was run in pre-submit, the others were run in post-submit). If this PR's CI signals are green, we should be good.

Which issue(s) this PR fixes:

Fixes #100551

Special notes for your reviewer:

/cc @alculquicondor @soltysh @ahg-g
/sig apps

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Adhityaa Chandrasekar added 2 commits March 25, 2021 06:36
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 25, 2021
@adtac adtac mentioned this pull request Mar 25, 2021
Closed
@adtac
Copy link
Author

adtac commented Mar 25, 2021

/retest

@adtac adtac mentioned this pull request Mar 25, 2021
Closed
@palnabarun
Copy link
Member

palnabarun commented Mar 25, 2021

/milestone v1.21
/priority critical-urgent

since the issue being solved by this PR is in the milestone and is critical urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 25, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 25, 2021
@ahg-g
Copy link
Member

ahg-g commented Mar 25, 2021

/lgtm

wow, good catch.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2021
@ahg-g
Copy link
Member

ahg-g commented Mar 25, 2021

We should backport this as far back as we can

@adtac
Copy link
Author

adtac commented Mar 25, 2021

The following mutation was triggered and detected by the feature gate=true, suspend=true->false subtest: http://ix.io/2U3u/diff

As you can see the mutation is entirely within the .status.conditions[0] Suspended condition. IMO the bug has always been around for a long time and was constantly being triggered, but we didn't observe it until now because:

  1. the mutation detector only runs on integration tests, and
  2. none of the job controller integration tests do a job Update() (TestSuspendJob is the first integration test to do that)

These are just possible hypotheses, I'm not 100% sure.

soltysh
soltysh approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@alculquicondor
Copy link
Member

alculquicondor commented Mar 25, 2021

+1 to cherrypicking

saschagrunert
saschagrunert approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, let's wait for this PR before cutting v1.21.0-rc.0 (kubernetes/sig-release#1489)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adtac, saschagrunert, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

saschagrunert commented Mar 25, 2021

/test pull-kubernetes-e2e-kind

@adtac
Copy link
Author

adtac commented Mar 25, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4333e5c into kubernetes:master Mar 25, 2021
@puerco puerco mentioned this pull request Mar 25, 2021
Closed
10 tasks
@ialidzhikov
Copy link
Contributor

ialidzhikov commented Jul 25, 2021

We should backport this as far back as we can

@adtac can you take care to backport this PR to the affected versions?

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Jul 28, 2021

We should backport this as far back as we can

@adtac can you take care to backport this PR to the affected versions?

Ping @adtac @ahg-g

/cc @janetkuo

@k8s-ci-robot k8s-ci-robot requested a review from janetkuo July 28, 2021 20:04
@alculquicondor
Copy link
Member

alculquicondor commented Jul 28, 2021

@ialidzhikov could you handle this?

See https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md for instructions

@adtac
Copy link
Author

adtac commented Jul 28, 2021

I'll do this tomorrow 👍

@adtac
Copy link
Author

adtac commented Aug 4, 2021

1.20: #104129
1.19: #104130
1.18: #104132
1.17: #104133

@cpanato
Copy link
Member

cpanato commented Sep 1, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2021
@alculquicondor alculquicondor mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@ahg-g ahg-g

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

[Failing Test] k8s.io/kubernetes/test/integration/job.TestMain (ci-kubernetes-integration-master)

9 participants

@adtac @palnabarun @ahg-g @alculquicondor @k8s-ci-robot @saschagrunert @ialidzhikov @cpanato @soltysh