Skip to content

Investigate callers of IsLikelyNotMountPoint #72347

@msau42

Description

@msau42

What happened:
IsLikelyNotMountPoint() doesn't detect bind mounts of directories on the same fs as /var/lib/kubelet. Local PVs that are directories on the rootfs are most problematic. Similar CSI plugins that expose rootfs directories are also problematic.

This commit identifies some functions that are technically incorrect because they use IsLikelyNotMountPoint() instead of IsNotMountPoint(). However, IsNotMountPoint() is expensive since it has to scan all mount points on the host, so instead of changing the callers to use IsNotMountPoint(), we found other ways to fix the problem.

We should investigate all other uses of IsLikelyNotMountPoint() to see if these cases are handled.

@kubernetes/sig-storage-bugs

/kind bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.sig/storageCategorizes an issue or PR as relevant to SIG Storage.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions