Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job objects are not cleaned up #64470

Closed
lavalamp opened this issue May 29, 2018 · 2 comments · Fixed by #66840
Closed

Job objects are not cleaned up #64470

lavalamp opened this issue May 29, 2018 · 2 comments · Fixed by #66840
Assignees
@janetkuo @kow3ns
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@lavalamp
Copy link
Member

/kind bug
/sig apps

It's easy to make jobs and forget to delete them. If you make enough of them, you can overload a control plane (which is typically sized to support the number of nodes and not an arbitrarily high number of jobs).

We have a "podgc" for deleting terminated pods if too many of them build up, so there is precedent.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels May 29, 2018
@lavalamp
Copy link
Member Author

@kow3ns @janetkuo

@ceshihao ceshihao mentioned this issue Jun 11, 2018
Closed
@janetkuo janetkuo mentioned this issue Jun 22, 2018
Closed
@janetkuo
Copy link
Member

janetkuo commented Jul 18, 2018 •
edited
Loading

Was planning to solve this problem in a generic way: kubernetes/community#2287
Current plan is to solve this for Jobs only and then generalize it for other resources based on user feedback. See the design doc: https://goo.gl/YxtxTi and the KEP kubernetes/community#2552.

@kubernetes/sig-apps-feature-requests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2018
This was referenced Jul 18, 2018
Closed
Closed
Closed
@janetkuo janetkuo mentioned this issue Aug 23, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 5, 2018
Merge pull request #66840 from janetkuo/job-ttl
c50a347 
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```
@jlewi jlewi mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

@kow3ns kow3ns

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
No milestone
4 participants
@lavalamp @janetkuo @kow3ns @k8s-ci-robot