-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate KUBE_API_VERSIONS #63102
Labels
kind/bug
Categorizes issue or PR as related to a bug.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
Comments
+1 |
k8s-publishing-bot
added a commit
to kubernetes/code-generator
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this issue
Apr 27, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
openshift-publish-robot
pushed a commit
to openshift/kubernetes-sample-apiserver
that referenced
this issue
Jan 14, 2019
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
tamalsaha
pushed a commit
to gomodules/encoding
that referenced
this issue
Aug 10, 2021
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this issue
Sep 20, 2022
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove KUBE_API_VERSIONS Fixes kubernetes/kubernetes#63102 KUBE_API_VERSIONS is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore. Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.". Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured. We should remove this piece of legacy since it doesn't behave predictable server-side or client-side. @smarterclayton @lavalamp @kubernetes/sig-api-machinery-bugs ```release-note KUBE_API_VERSIONS is no longer respected. It was used for testing, but runtime-config is the proper flag to set. ``` Kubernetes-commit: dd5f030b023b7d9299c516d80fb281c36b6fc844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
KUBE_API_VERSIONS
is an attempt to control the available serialization of types. It pre-dates the idea that we'll have separate schemes, so it's not a thing that makes sense anymore.Server-side we've had a very clear message about breaks in the logs for a year "KUBE_API_VERSIONS is only for testing. Things will break.".
Client-side it became progressively more broken as we moved to generic types for CRUD more than a year ago. What is registered doesn't matter when everything is unstructured.
We should remove this piece of legacy since it doesn't behave predictable server-side or client-side.
@smarterclayton @lavalamp
@kubernetes/sig-api-machinery-bugs
The text was updated successfully, but these errors were encountered: