Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl patch --type=strategic should prompt the name of the required key #57834

Closed
mfojtik opened this issue Jan 4, 2018 · 4 comments
Closed

kubectl patch --type=strategic should prompt the name of the required key #57834

mfojtik opened this issue Jan 4, 2018 · 4 comments
Assignees
@mengqiy
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@mfojtik
Copy link
Contributor

mfojtik commented Jan 4, 2018

When running kubectl patch --type=strategic ... (--type=strategic is by default)

$ kubectl patch svc multi-portsvc --type=strategic -p '
spec:
  ports:
  - targetPort: 441'

or

$ oc patch rc rctest -p='
spec:
  template:
    spec:
      containers:
      - resources:
          limits:
            memory: 258Mi'

The output is:

The ReplicationController "rctest" is invalid: spec.template.spec.containers: Required value

Before, the output not ideal, but it at least showed the required key's name:
Error from server: map: map[targetPort:441] does not contain declared merge key: port

The recent version of kubectl seemed to dropped this message.

Possibly related: #51321
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 4, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 4, 2018

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 4, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 4, 2018 •
edited
Loading

@mengqiy @wanghaoran1988 FYI

@liggitt
Copy link
Member

liggitt commented Jan 4, 2018

/kind bug
/assign @mengqiy

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2018
@mengqiy mengqiy mentioned this issue Jan 5, 2018
Merged
@mengqiy
Copy link
Member

mengqiy commented Jan 5, 2018

The ReplicationController "rctest" is invalid: spec.template.spec.containers: Required value

This error message comes from server-side validation.

SMP should return an error message when the merge key is missing.

Sent a fix #57854

k8s-github-robot pushed a commit that referenced this issue Jan 5, 2018
Merge pull request #57854 from mengqiy/fix_SMP
51345de 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix bug of swallowing missing merge key error

The bug is caused by variable shadowing.

Fixes #57834

```release-note
NONE
```

/assign @liggitt
@redbaron redbaron mentioned this issue Jun 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengqiy mengqiy

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfojtik @liggitt @mengqiy @k8s-ci-robot