Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong format string in describers #57694

Closed
stewart-yu opened this issue Dec 29, 2017 · 2 comments · Fixed by #57399
Closed

Wrong format string in describers #57694

stewart-yu opened this issue Dec 29, 2017 · 2 comments · Fixed by #57399
Assignees
@php-coder
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@stewart-yu
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
when i create PersistentVolume, yaml like that:

apiVersion: v1
kind: PersistentVolume
metadata:
  name: pv-flex-lvm
spec:
  capacity:
    storage: 0.1Gi
  accessModes:
    - ReadWriteOnce
  flexVolume:
    driver: foo/lvm

than describe it, got :

Name:            pv-flex-lvm
Labels:          <none>
Annotations:     kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"v1","kind":"PersistentVolume","metadata":{"annotations":{},"name":"pv-flex-lvm","namespace":""},"spec":{"accessModes":["ReadWriteOnce"],...
StorageClass:    
Status:          Available
Claim:           
Reclaim Policy:  Retain
Access Modes:    RWO
Capacity:        107374182400m
Message:         
Source:
    Type:    FlexVolume (a generic volume resource that is provisioned/attached using an exec based plugin)
    Driver:      Options:  %v

    FSType:                                           foo/lvm
    SecretRef:                                        
    ReadOnly:                                         <nil>
%!(EXTRA bool=false, map[string]string=map[])Events:  <none>

What you expected to happen:
Like that:

Name:            pv-flex-lvm
Labels:          <none>
Annotations:     kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"v1","kind":"PersistentVolume","metadata":{"annotations":{},"name":"pv-flex-lvm","namespace":""},"spec":{"accessModes":["ReadWriteOnce"],...
StorageClass:    
Status:          Available
Claim:           
Reclaim Policy:  Retain
Access Modes:    RWO
Capacity:        107374182400m
Message:         
Source:
    Type:       FlexVolume (a generic volume resource that is provisioned/attached using an exec based plugin)
    Driver:     foo/lvm
    FSType:     
    SecretRef:  <nil>
    ReadOnly:   false
    Options:    map[]
Events:         <none>

How to reproduce it (as minimally and precisely as possible):
What's said in What happened

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): master
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Dec 29, 2017
@stewart-yu stewart-yu mentioned this issue Dec 29, 2017
Closed
@stewart-yu
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 29, 2017
@dixudx
Copy link
Member

dixudx commented Dec 29, 2017

Already got PR #57399 to fix this.
/assign @php-coder

@zjj2wry zjj2wry mentioned this issue Dec 29, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jan 2, 2018
Merge pull request #57399 from php-coder/fix_flex_pvs_describe
a0f8dd8 
Automatic merge from submit-queue (batch tested with PRs 57399, 57751, 57475). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

printFlexPersistentVolumeSource: fix format

**What this PR does / why we need it**:
This PR fixes invalid format.

**Special notes for your reviewer**:
Addresses #56460 (comment)
Fixes #57694

**Release note**:
```release-note
NONE
```

PTAL @liggitt 
CC @simo5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
4 participants
@php-coder @dixudx @k8s-ci-robot @stewart-yu