Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need e2e test for configurable pod resolv.conf (a.k.a CustomPodDNS) #56521

Closed
MrHohn opened this issue Nov 29, 2017 · 1 comment · Fixed by #59771
Closed

Need e2e test for configurable pod resolv.conf (a.k.a CustomPodDNS) #56521

MrHohn opened this issue Nov 29, 2017 · 1 comment · Fixed by #59771
Assignees
@MrHohn
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@MrHohn
Copy link
Member

MrHohn commented Nov 29, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
/sig network

What happened:
From kubernetes/enhancements#504.

#55848 adds the Alpha support for Custom Pod DNS, given this is an opt-in feature that will not be triggered by any existing e2e test, we should write a explicit test to ensure it is and will be continue working.

/assign
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 29, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Nov 29, 2017

cc @lookuptable FYI

@MrHohn MrHohn mentioned this issue Feb 12, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 25, 2018
Merge pull request #59771 from MrHohn/custom-pod-dns-e2e
ac25308 
Automatic merge from submit-queue (batch tested with PRs 60324, 60269, 59771, 60314, 59941). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Promote configurable pod resolv.conf to Beta and add an e2e test

**What this PR does / why we need it**:
Feature issue: kubernetes/enhancements#504

There is no semantic changes. `CustomPodDNS` feature gate will be turned on by default.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56521

**Special notes for your reviewer**:
/assign @bowei @thockin 

**Release note**:

```release-note
Adds BETA support for `DNSConfig` field in PodSpec and `DNSPolicy=None`.
```
@MrHohn MrHohn mentioned this issue Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrHohn MrHohn

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promote configurable pod resolv.conf to Beta and add an e2e test MrHohn/kubernetes
2 participants
@MrHohn @k8s-ci-robot