Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service IP and Port allocator repair controllers do not send events on errors #54303

Closed
frodenas opened this issue Oct 20, 2017 · 1 comment · Fixed by #54304
Closed

Service IP and Port allocator repair controllers do not send events on errors #54303

frodenas opened this issue Oct 20, 2017 · 1 comment · Fixed by #54304
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.

Comments

@frodenas
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

Service IP and Port allocator repair controllers do NOT send events on errors, they only log the error, making it difficult to diagnosticate when there is an error (ie Service CIDR or Port Range full).

What you expected to happen:

Repair controllers should emit an event, so looking at the Service events one can easily find why it does not have a Cluster IP or a Port exposed.

How to reproduce it (as minimally and precisely as possible):

n/a
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 20, 2017
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 20, 2017
@frodenas frodenas mentioned this issue Oct 20, 2017
Merged
@frodenas
Copy link
Contributor Author

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Oct 20, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 20, 2017
k8s-github-robot pushed a commit that referenced this issue Dec 15, 2017
Merge pull request #54304 from frodenas/repair-events
dd4f84f 
Automatic merge from submit-queue (batch tested with PRs 56308, 54304, 56364, 56388, 55853). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Send events on certain service repair controller errors

**What this PR does / why we need it**:

This PR enables sending events when the api-server service IP and port allocator repair controllers find an error repairing a cluster ip or a port respectively.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54303

**Special notes for your reviewer**:

In case of an error, events will be emitted [every 3 minutes](https://github.com/kubernetes/kubernetes/blob/master/pkg/master/controller.go#L93) for each failed Service. Even so, event spam protection has been merged (#47367) to mitigate the risk of excessive events.

**Release note**:

```release-note
api-server provides specific events when unable to repair a service cluster ip or node port
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send events on certain service repair controller errors
3 participants
@frodenas @k8s-github-robot @k8s-ci-robot