Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete in-tree support for Nvidia GPUs #54012

Closed
vishh opened this issue Oct 16, 2017 · 14 comments
Closed

Delete in-tree support for Nvidia GPUs #54012

vishh opened this issue Oct 16, 2017 · 14 comments
Assignees
@rohitagarwal003 @jiayingz
Labels
area/hw-accelerators kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. milestone/removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@vishh
Copy link
Contributor

vishh commented Oct 16, 2017

Nvidia GPU support is currently available via the kubelet directly. This support has been deprecated in favor of device plugins. Since we don't have a device plugin for all distros, deleting the old support isn't advisable just yet.
I'm hoping we can delete the old implementation which works by setting Accelerators=true feature gate in v1.10 release cycle.

Depends on #54011

#53497 for tracking
@vishh vishh added area/hw-accelerators sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 16, 2017
@vishh vishh added this to the v1.10 milestone Oct 16, 2017
@resouer resouer mentioned this issue Oct 18, 2017
Closed
@tianshapjq
Copy link
Contributor

/cc

2 similar comments
@jianzhangbjz
Copy link
Contributor

/cc

@ScorpioCPH
Copy link
Contributor

/cc

@dims
Copy link
Member

dims commented Jan 28, 2018

per comment from @mindprince looks like we need to move this milestone to v1.11 (#54101 (comment))

@jiayingz
Copy link
Contributor

+1 for moving it to v1.11. We will announce the deprecation in v1.10.

@jberkus
Copy link

jberkus commented Feb 3, 2018

please add kind/ and priority/ labels to this issue for 1.10. Thanks.

@rohitagarwal003
Copy link
Member

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 3, 2018
@jberkus
Copy link

jberkus commented Feb 21, 2018

since #54011 appears to be delayed, please make a decision on this issue ASAP. are we announcing deprecation if the new GPU support isn't ready?

@jiayingz
Copy link
Contributor

We mark the feature as deprecated in 1.10. Will remove the in-tree code in 1.11. Please feel free to move the milestone to 1.11.

@jberkus jberkus mentioned this issue Feb 21, 2018
Closed
@jberkus
Copy link

jberkus commented Feb 23, 2018

OK, is there a separate issue (maybe a Doc issue) for announcing deprecation?

@rohitagarwal003
Copy link
Member

The GPU doc (https://kubernetes.io/docs/tasks/manage-gpus/scheduling-gpus/) was already updated to say:

The Accelerators feature gate and alpha.kubernetes.io/nvidia-gpu resource works on 1.8 and 1.9 as well. It will be deprecated in 1.10 and removed in 1.11.

This should also appear in 1.10 release notes: #57384

@rohitagarwal003
Copy link
Member

@jberkus Can you please move this to 1.11 milestone (that's when we will delete the code).

/assign

@jberkus
Copy link

jberkus commented Feb 26, 2018

@mindprince a sig lead needs to change the milestone. Automation will remove 1.10 in 7 hours, but it won't put 1.11 in.

@vishh vishh modified the milestones: v1.10, v1.11 Feb 26, 2018
@rohitagarwal003 rohitagarwal003 mentioned this issue Mar 21, 2018
Merged
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Issue

@jiayingz @mindprince @vishh @kubernetes/sig-node-misc

Important: This issue was missing the status/approved-for-milestone label for more than 7 days.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.11 milestone Mar 27, 2018
k8s-github-robot pushed a commit that referenced this issue Apr 3, 2018
Merge pull request #61498 from mindprince/delete-in-tree-gpu
043204b 
Automatic merge from submit-queue (batch tested with PRs 61498, 62030). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Delete in-tree support for NVIDIA GPUs.

This removes the alpha Accelerators feature gate which was deprecated in 1.10 (#57384).
The alternative feature DevicePlugins went beta in 1.10 (#60170).

Fixes #54012

```release-note
Support for "alpha.kubernetes.io/nvidia-gpu" resource which was deprecated in 1.10 is removed. Please use the resource exposed by DevicePlugins instead ("nvidia.com/gpu").
```
@bhack bhack mentioned this issue Apr 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitagarwal003 rohitagarwal003

@jiayingz jiayingz

Labels
area/hw-accelerators kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. milestone/removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@dims @jberkus @rohitagarwal003 @ScorpioCPH @vishh @k8s-github-robot @jianzhangbjz @k8s-ci-robot @tianshapjq @jiayingz