Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreatedByAnnotation in v1.9, in favor of ControllerRef #50720

Closed
crimsonfaith91 opened this issue Aug 15, 2017 · 2 comments · Fixed by #54445
Closed

Remove CreatedByAnnotation in v1.9, in favor of ControllerRef #50720

crimsonfaith91 opened this issue Aug 15, 2017 · 2 comments · Fixed by #54445
Assignees
@crimsonfaith91
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.9

Comments

@crimsonfaith91
Copy link
Contributor

crimsonfaith91 commented Aug 15, 2017 •
edited
Loading

CreatedByAnnotation will be deprecated in v1.8 and be removed in v1.9, in favor of ControllerRef.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 15, 2017
@enisoc enisoc added this to the v1.9 milestone Aug 17, 2017
@enisoc
Copy link
Member

enisoc commented Aug 17, 2017

ref #50536

@enisoc enisoc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 5, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Issue Current

@crimsonfaith91

Issue Labels
  • sig/apps: Issue will be escalated to these SIGs if needed.
  • priority/important-longterm: Escalate to the issue owners; move out of the milestone after 1 attempt.
  • kind/feature: New functionality.
Help

@crimsonfaith91 crimsonfaith91 mentioned this issue Oct 24, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Nov 1, 2017
Merge pull request #54445 from crimsonfaith91/rem
ed00d9c 
Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove created-by annotation

**What this PR does / why we need it**:
This PR removes `CreatedByAnnotation`.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50720

**Release note**:

```release-note
The `kubernetes.io/created-by` annotation is no longer added to controller-created objects. Use the  `metadata.ownerReferences` item that has `controller` set to `true` to determine which controller, if any, owns an object.
```
hiddeco pushed a commit to hiddeco/kubernetes that referenced this issue Apr 6, 2020
Merge pull request kubernetes#54445 from crimsonfaith91/rem
56c6a71 
Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove created-by annotation

**What this PR does / why we need it**:
This PR removes `CreatedByAnnotation`.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes#50720

**Release note**:

```release-note
The `kubernetes.io/created-by` annotation is no longer added to controller-created objects. Use the  `metadata.ownerReferences` item that has `controller` set to `true` to determine which controller, if any, owns an object.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crimsonfaith91 crimsonfaith91

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

remove created-by annotation crimsonfaith91/kubernetes
4 participants
@enisoc @k8s-github-robot @crimsonfaith91 @k8s-ci-robot