Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move workload API objects to group version apps/v1beta2 #49135

Closed
11 tasks done
kow3ns opened this issue Jul 18, 2017 · 16 comments
Closed
11 tasks done

Move workload API objects to group version apps/v1beta2 #49135

kow3ns opened this issue Jul 18, 2017 · 16 comments
Assignees
@janetkuo
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.8

Comments

@kow3ns
Copy link
Member

kow3ns commented Jul 18, 2017 •
edited
Loading

FEATURE REQUEST: Create a new version in the apps group for the core workloads API.
When we advance the core workloads API (DaemonSet, Deployment, ReplicaSet, and StatefulSet) to v1, we want them to advance as a group and be (where possible) consistent. Prior to doing so, we would like to make any API incompatible changes. In particular we will

We may find other incompatible changes that are required prior to promotion, and we would like to make them in this version, prior to releasing it. When the community is satisfied with the API surface, as contained in this version, and it is stable, we would like to promote all of the core workloads API to GA by moving the contained API to v1.

kubernetes/enhancements#353
/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Jul 18, 2017

/assign @janetkuo

@k8s-github-robot
Copy link

@kow3ns
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 18, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Jul 18, 2017

@kubernetes/sig-apps-api-reviews
@kubernetes/sig-apps-feature-requests
/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Jul 18, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 18, 2017
@kow3ns kow3ns mentioned this issue Jul 18, 2017
Merged
@janetkuo janetkuo added this to the v1.8 milestone Jul 18, 2017
@foxish foxish mentioned this issue Jul 18, 2017
Merged
@bgrant0607
Copy link
Member

@kow3ns What's the corresponding issue in the features repo?

@janetkuo janetkuo mentioned this issue Jul 19, 2017
Merged
@kow3ns
Copy link
Member Author

kow3ns commented Jul 19, 2017

@bgrant0607 ref

k8s-github-robot pushed a commit that referenced this issue Jul 21, 2017
Merge pull request #48746 from janetkuo/apps-v1beta2
ae1ff1a 
Automatic merge from submit-queue

Add a new API version apps/v1beta2

xref: #49135
This PR adds a new API version `apps/v1beta2` which contains a copy (of types, conversions, and defaults) of `apps/v1beta1` StatefulSet, Deployment, and their subresources. Note that `apps/v1beta2` is still WIP and we will make breaking changes to it before releasing 1.8.

Moving core controllers (StatefulSet, Deployment, ReplicaSet, DaemonSet) to `apps/v1beta2` is the first step of moving them to `apps/v1` (GA). 

This PR is a starting point for DaemonSet and ReplicaSet to move from `/extensions` to `/apps` and for Deployment and StatefulSet to make some breaking changes (e.g. new defaults and/or remove deprecated fields).

```release-note
Add a new API version apps/v1beta2
```
@janetkuo janetkuo mentioned this issue Jul 21, 2017
Closed
2 tasks
@lukaszo
Copy link
Contributor

lukaszo commented Jul 21, 2017

Is this a good moment to make RollingUpdate DS strategy a default? Like in Deployments. Or this will never happen?

@janetkuo janetkuo mentioned this issue Jul 22, 2017
Merged
@0xmichalis
Copy link
Contributor

Is this a good moment to make RollingUpdate DS strategy a default? Like in Deployments. Or this will never happen?

Yes, new api version means we can change the defaults. +1 on making rolling updates the default.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 22, 2017 via email

@janetkuo
Copy link
Member

janetkuo commented Jul 26, 2017 •
edited
Loading

Yes, we planned to make StS and DS default strategy to be RollingUpdate. Tracked in #49604

@dixudx dixudx mentioned this issue Jul 26, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 26, 2017
Merge pull request #49071 from foxish/foxish-api
4399fb2 
Automatic merge from submit-queue (batch tested with PRs 43443, 46193, 49071, 47252)

Add v1beta2.DaemonSet

Depends on #48746
Partly implements #49135

```release-note
Adding type apps/v1beta2.DaemonSet
```
@dixudx dixudx mentioned this issue Jul 26, 2017
Closed
k8s-github-robot pushed a commit that referenced this issue Jul 28, 2017
Merge pull request #49238 from janetkuo/apps-v1beta2-rs
7056b5b 
Automatic merge from submit-queue (batch tested with PRs 49238, 49595, 43494, 47897, 48905)

Add apps/v1beta2.ReplicaSet

~Depends on #48746~ (merged)
~Depends on #49357~ (merged)
xref: #49135

```release-note
Add a new API object apps/v1beta2.ReplicaSet
```
@bgrant0607 bgrant0607 mentioned this issue Aug 1, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 3, 2017
Merge pull request #49607 from dixudx/change_StS_observedGeneration_t…
6f99ed4 
…o_int

Automatic merge from submit-queue (batch tested with PRs 50000, 49954, 49943, 50018, 49607)

change apps/v1beta2 StatefulSet observedGeneration from a pointer to an int for consistency

**What this PR does / why we need it**:
change the StatefulSet observedGeneration from a pointer to an int for consistency

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49623
xref #49135

**Special notes for your reviewer**:
/cc @janetkuo @foxish @kow3ns 

**Release note**:

```release-note
change apps/v1beta2 StatefulSet observedGeneration (optional field) from a pointer to an int for consistency
```
k8s-github-robot pushed a commit that referenced this issue Aug 9, 2017
Merge pull request #49340 from janetkuo/apps-v1beta2-dep-rollback
2bd2127 
Automatic merge from submit-queue

Deprecate Deployment .spec.rollbackTo field 

~Depends on #48746~ (merged)
xref: #46934, #49135

1. Deprecate Deployment field `.spec.rollbackTo` in `extensions/v1beta1` and `apps/v1beta1`, and remove the same field and `/rollback` endpoint from `apps/v1beta2` Deployment. 
1. Add an annotation `deprecated.deployment.rollback.to` in `apps/v1beta2` for conversion to/from other versions. 

Note: `apps/v1beta2` is new in 1.8 (and WIP), so it is okay to make breaking changes to it. 

```release-note
Deprecate Deployment .spec.rollbackTo field 
```
@dixudx
Copy link
Member

dixudx commented Sep 5, 2017

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 5, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Labels Complete

@janetkuo @kow3ns

Issue label settings:

  • sig/apps: Issue will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/feature: New functionality.
Additional instructions available here The commands available for adding these labels are documented here

@bgrant0607
Copy link
Member

@kow3ns Has it been figured out how PodDisruptionBudget will be taken into account by controllers other than StatefulSet, and how its maxUnvailable specification would relate to that specified by the controller's update strategy?

@kow3ns
Copy link
Member Author

kow3ns commented Sep 13, 2017

@bgrant0607 Controllers don't create evictions or drain. For each controller, workload owners specify the desired number of disruptions during rollouts, rollbacks, turn ups, and turn downs using the parameters of the corresponding objects.

A PDB represents a contract between workload owners and cluster admins so that the former has a means to specify the tolerated number of disruptions to the latter.

The two concepts inter-operate and are related, but controllers (other than EvictionController) are agnostic to the PDB, and EvictionController is agnostic to the parameters of the workload specification.

@dims
Copy link
Member

dims commented Sep 18, 2017

@kow3ns looks like there was a lot of progress, can we close this out or move this out of 1.8 milestone please?

@jdumars jdumars modified the milestones: v1.8, v1.9 Sep 20, 2017
@kow3ns kow3ns modified the milestones: v1.9, v1.8 Sep 20, 2017
@kow3ns
Copy link
Member Author

kow3ns commented Sep 20, 2017

/close

@kow3ns
Copy link
Member Author

kow3ns commented Sep 20, 2017

shipped 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests