Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows/amd64 cross-build is broken: vendor/github.com/docker/docker/pkg/term/windows #48887

Closed
ixdy opened this issue Jul 13, 2017 · 7 comments · Fixed by #48933 or #48972
Closed

windows/amd64 cross-build is broken: vendor/github.com/docker/docker/pkg/term/windows #48887

ixdy opened this issue Jul 13, 2017 · 7 comments · Fixed by #48933 or #48972
Assignees
@brendandburns
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@ixdy
Copy link
Member

ixdy commented Jul 13, 2017 •
edited
Loading

The windows/amd64 cross-build has been failing since yesterday morning.
From https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-cross-build/2320:

I0712 10:13:02.637] +++ [0712 10:11:46] windows/amd64: go build started
I0712 10:13:02.637] # k8s.io/kubernetes/vendor/github.com/docker/docker/pkg/term/windows
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:139: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:146: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:210: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:210: undefined: winterm.DWORD
I0712 10:13:02.638] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:226: undefined: winterm.DWORD

It looks like #47140 is the culprit. The Azure dependencies were updated, but docker wasn't updated to support the changes until 1.12, and we vendor 1.11.

/assign @brendandburns
/cc @krousey @kubernetes/sig-windows-bugs
@k8s-ci-robot
Copy link
Contributor

@ixdy: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members can be assigned.

In response to this:

The windows/amd64 cross-build has been failing since yesterday morning.
From https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-cross-build/2320:

I0712 10:13:02.637] +++ [0712 10:11:46] windows/amd64: go build started
I0712 10:13:02.637] # k8s.io/kubernetes/vendor/github.com/docker/docker/pkg/term/windows
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:139: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:146: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:210: undefined: winterm.WORD
I0712 10:13:02.637] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:210: undefined: winterm.DWORD
I0712 10:13:02.638] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:226: undefined: winterm.DWORD

It looks like #47140 is the culprit. The Azure dependencies were updated, but docker wasn't updated to support the changes until 1.12, and we vendor 1.11.

/assign @brendanburns
/cc @krousey @kubernetes/sig-windows-bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/bug Categorizes issue or PR as related to a bug. labels Jul 13, 2017
@ixdy ixdy mentioned this issue Jul 13, 2017
Merged
@ixdy
Copy link
Member Author

ixdy commented Jul 13, 2017

hm, I guess sig-windows is probably not the right group here. sorry for the spam!

@ixdy ixdy added area/platform/azure and removed sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jul 13, 2017
@brendandburns
Copy link
Contributor

I'll get a fix for this sometime today...

apologies!

This was referenced Jul 13, 2017
Merged
Merged
Merged
Closed
Merged
Closed
@cblecker
Copy link
Member

Multiple PRs failing cross builds at the moment
/priority failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 14, 2017
@karataliu karataliu mentioned this issue Jul 14, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 14, 2017
Merge pull request #48933 from karataliu/fixwinbuild
726184c 
Automatic merge from submit-queue (batch tested with PRs 47066, 48892, 48933, 48854, 48894)

Fix windows build by altering go-ansiterm version

**What this PR does / why we need it**:
An attempt to fix windows build break in #48887, moves `github.com/Azure/go-ansiterm` to Azure/go-ansiterm@70b2c90.
We can upgrade to new version when we pick docker 1.12

See also:
moby/moby@fab67ab#diff-c36e523b64f1ca41293e912113063a92L9

**Which issue this PR fixes**
Fixes #48887 

**Special notes for your reviewer**:

**Release note**:
@ixdy
Copy link
Member Author

ixdy commented Jul 15, 2017

And now we're broken again:

I0714 17:04:14.667] # k8s.io/kubernetes/vendor/github.com/docker/docker/pkg/term/windows
I0714 17:04:14.667] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:192: cannot use keyEvent.VirtualKeyCode (type winterm.WORD) as type uint16 in argument to formatVirtualKey
I0714 17:04:14.667] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:192: cannot use keyEvent.ControlKeyState (type winterm.DWORD) as type uint32 in argument to formatVirtualKey
I0714 17:04:14.667] vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:195: cannot use keyEvent.ControlKeyState (type winterm.DWORD) as type uint32 in argument to getControlKeys

It seems that #48308 updated the docker dependency, which made the go-ansiterm revert in #48933 now incorrect.

cc @karataliu @yguo0905 @yujuhong @dchen1107

@ixdy ixdy reopened this Jul 15, 2017
This was referenced Jul 15, 2017
Merged
Merged
@karataliu
Copy link
Contributor

karataliu commented Jul 15, 2017 •
edited
Loading

@ixdy twists and turns here
Yeah, since we have got an updated docker version now, we can revert the go-ansiterm version downgrade change #48933. Thanks for the follow up.

Is the cross-build test a required one for check-in now? If it is, then no such breaks would happen.

@cblecker
Copy link
Member

It isn't by default.. I believe this is because it's long running and resource intensive.

@ixdy: is it potentially worth adding Godeps to the cross-build run_if_changed list? I don't know if this could prevent this in the future, or if it would just consume a lot of resources for very little gain (if this is a corner case).

@crassirostris crassirostris mentioned this issue Jul 17, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 17, 2017
Merge pull request #48972 from ixdy/revert-pr-48933
d20414e 
Automatic merge from submit-queue (batch tested with PRs 48997, 48595, 48898, 48711, 48972)

Revert "Use go-ansiterm version matching docker/pkg/term/windows v1.11"

This reverts commit 72044a1.

**What this PR does / why we need it**: earlier this week, #47140 updated the vendored azure dependencies, which broke the windows build because the docker dependencies were too old. #48933 was merged, which reverted part of #47140 and fixed the build, but then #48308, which updated the vendored docker dependencies, broke the windows build again.

By reverting #48933, we should get back to a working build, I hope.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48887

**Release note**:

```release-note
NONE
```
/release-note-none
/test pull-kubernetes-cross
/assign @brendandburns 
cc @karataliu @yguo0905 @yujuhong @dchen1107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendandburns brendandburns

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
5 participants
@cblecker @brendandburns @ixdy @karataliu @k8s-ci-robot