-
Notifications
You must be signed in to change notification settings - Fork 42.9k
Consider expanding service names #3752
Copy link
Copy link
Closed
Labels
area/apiIndicates an issue on api area.Indicates an issue on api area.priority/awaiting-more-evidenceLowest priority. Possibly useful, but not yet enough support to actually get it done.Lowest priority. Possibly useful, but not yet enough support to actually get it done.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
Metadata
Metadata
Assignees
Labels
area/apiIndicates an issue on api area.Indicates an issue on api area.priority/awaiting-more-evidenceLowest priority. Possibly useful, but not yet enough support to actually get it done.Lowest priority. Possibly useful, but not yet enough support to actually get it done.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
Filing this so we can revisit.
@satnam6502
Service names (and apparently Namespace names in the client, but not the server) are restricted to DNS 952 labels (24 characters). Most other API Objects have names that are DNS 1123 subdomains (much longer).
In doing tests it is useful to generate random names, and this is a bit annoying for services.
Can we expand service names?
(4) would be most consistent with other objects.
If we do (2) or (4) we need to convert dots to underscores in env-var names, which could cause a collision (e.g. foo-bar and foo.bar). Maybe double underscore for dots?
If we do (3) or (4) we need to handle leading digits in env-vars. Maybe a prefixed underscore?
(1) seems least controversial, but is still different than everything else.