Skip to content

Unhelpful feature gate name EnableWorkloadWithJob #138204

@lmktfy

Description

@lmktfy

What happened?

We try not to put "Enable" or "Disable" in the names of feature gates, because feature gates are themselves things you enable and disable.

Maybe one day we'll have a lint for this; in the meantime, I see that EnableWorkloadWithJob has slipped through.

Is it too late to change this for v1.36? I hope not.

/sig architecture

What did you expect to happen?

Feature gate names follow our soft conventions.

How can we reproduce it (as minimally and precisely as possible)?

Look at the main branch code as of d3b9c54

Anything else we need to know?

No response

Kubernetes version

1.36

Cloud provider

n/a

OS version

n/a

Install tools

Details

Container runtime (CRI) and version (if applicable)

n/a

Related plugins (CNI, CSI, ...) and versions (if applicable)

n/a

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.sig/appsCategorizes an issue or PR as relevant to SIG Apps.sig/architectureCategorizes an issue or PR as relevant to SIG Architecture.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

Status

Closed

Status

Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions