-
Notifications
You must be signed in to change notification settings - Fork 43k
Stop vendoring runc / libcontainer #104325
Copy link
Copy link
Closed as not planned
Labels
kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.
Description
Metadata
Metadata
Assignees
Labels
kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.
What happened:
Kubernetes vendors runc, for example to cleanup stale cgroups.
kubernetes/go.mod
Line 367 in e7efe21
What you expected to happen:
We should not rely on lower level libraries like libcontainer, because they do not guarantee anything in terms of stability. The only valid interface of lower level OCI runtimes is their CLI. Updating runc in a cluster already has impact in the whole stack and from my point of view we should maintain parallel implementations rather than having to many moving parts.
Anything else we need to know?:
Ref: #104280