WIP debug

kolyshkin · kolyshkin · commit ee22f6d717af · 2021-12-21T19:33:53.000-08:00
Signed-off-by: Kir Kolyshkin &lt;kolyshkin@gmail.com&gt;
diff --git a/pkg/kubelet/cm/cgroup_manager_linux.go b/pkg/kubelet/cm/cgroup_manager_linux.go
@@ -314,6 +314,8 @@ func (m *cgroupManagerImpl) Destroy(cgroupConfig *CgroupConfig) error {
 		return err
 	}
 
+	klog.V(4).Infof("KKK builtPaths: %+v", m.buildCgroupPaths(cgroupConfig.Name))
+	klog.V(4).Infof("KKK Removing cgroup: %+v", cgroupConfig.Name, "paths: ", manager.GetPaths())
 	// Delete cgroups using libcontainer cgroup manager's Destroy() method.
 	if err = manager.Destroy(); err != nil {
 		return fmt.Errorf("unable to destroy cgroup paths for cgroup %v : %v", cgroupConfig.Name, err)
@@ -457,6 +459,8 @@ func (m *cgroupManagerImpl) Update(cgroupConfig *CgroupConfig) error {
 	if err != nil {
 		return fmt.Errorf("failed to create cgroup manager: %v", err)
 	}
+	klog.V(4).Infof("KKK builtPaths: %+v", m.buildCgroupPaths(cgroupConfig.Name))
+	klog.V(4).Infof("KKK Updating cgroup: %v, paths: %+v", cgroupConfig.Name, manager.GetPaths())
 
 	return manager.Set(config.Resources)
 }
@@ -475,6 +479,7 @@ func (m *cgroupManagerImpl) Create(cgroupConfig *CgroupConfig) error {
 		return err
 	}
 
+	klog.V(4).Infof("KKK Creating cgroup: %v, config: %+v", cgroupConfig.Name, config)
 	// Apply(-1) is a hack to create the cgroup directories for each resource
 	// subsystem. The function [cgroups.Manager.apply()] applies cgroup
 	// configuration to the process with the specified pid.
@@ -484,6 +489,8 @@ func (m *cgroupManagerImpl) Create(cgroupConfig *CgroupConfig) error {
 	if err := manager.Apply(-1); err != nil {
 		return err
 	}
+	klog.V(4).Infof("KKK builtPaths: %+v ", m.buildCgroupPaths(cgroupConfig.Name))
+	klog.V(4).Infof("KKK Created cgroup: %v, paths: %+v", cgroupConfig.Name, manager.GetPaths())
 
 	// it may confuse why we call set after we do apply, but the issue is that runc
 	// follows a similar pattern.  it's needed to ensure cpu quota is set properly.

Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,8 @@ func (m cgroupManagerImpl) Destroy(cgroupConfig CgroupConfig) error {`
`314`	`314`	`return err`
`315`	`315`	`}`
`316`	`316`
	`317`	`+ klog.V(4).Infof("KKK builtPaths: %+v", m.buildCgroupPaths(cgroupConfig.Name))`
	`318`	`+ klog.V(4).Infof("KKK Removing cgroup: %+v", cgroupConfig.Name, "paths: ", manager.GetPaths())`
`317`	`319`	`// Delete cgroups using libcontainer cgroup manager's Destroy() method.`
`318`	`320`	`if err = manager.Destroy(); err != nil {`
`319`	`321`	`return fmt.Errorf("unable to destroy cgroup paths for cgroup %v : %v", cgroupConfig.Name, err)`
`@@ -457,6 +459,8 @@ func (m cgroupManagerImpl) Update(cgroupConfig CgroupConfig) error {`
`457`	`459`	`if err != nil {`
`458`	`460`	`return fmt.Errorf("failed to create cgroup manager: %v", err)`
`459`	`461`	`}`
	`462`	`+ klog.V(4).Infof("KKK builtPaths: %+v", m.buildCgroupPaths(cgroupConfig.Name))`
	`463`	`+ klog.V(4).Infof("KKK Updating cgroup: %v, paths: %+v", cgroupConfig.Name, manager.GetPaths())`
`460`	`464`
`461`	`465`	`return manager.Set(config.Resources)`
`462`	`466`	`}`
`@@ -475,6 +479,7 @@ func (m cgroupManagerImpl) Create(cgroupConfig CgroupConfig) error {`
`475`	`479`	`return err`
`476`	`480`	`}`
`477`	`481`
	`482`	`+ klog.V(4).Infof("KKK Creating cgroup: %v, config: %+v", cgroupConfig.Name, config)`
`478`	`483`	`// Apply(-1) is a hack to create the cgroup directories for each resource`
`479`	`484`	`// subsystem. The function [cgroups.Manager.apply()] applies cgroup`
`480`	`485`	`// configuration to the process with the specified pid.`
`@@ -484,6 +489,8 @@ func (m cgroupManagerImpl) Create(cgroupConfig CgroupConfig) error {`
`484`	`489`	`if err := manager.Apply(-1); err != nil {`
`485`	`490`	`return err`
`486`	`491`	`}`
	`492`	`+ klog.V(4).Infof("KKK builtPaths: %+v ", m.buildCgroupPaths(cgroupConfig.Name))`
	`493`	`+ klog.V(4).Infof("KKK Created cgroup: %v, paths: %+v", cgroupConfig.Name, manager.GetPaths())`
`487`	`494`
`488`	`495`	`// it may confuse why we call set after we do apply, but the issue is that runc`
`489`	`496`	`// follows a similar pattern. it's needed to ensure cpu quota is set properly.`