Skip to content

promote releng ci 1.18-bullseye-0 tag#3539

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cpanato:promote-releng-ci
Mar 21, 2022
Merged

promote releng ci 1.18-bullseye-0 tag#3539
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cpanato:promote-releng-ci

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Mar 19, 2022

Image promotion for releng-image 1.18-bullseye

/assign @justaugustus @puerco @xmudrii @Verolop @palnabarun

Part of kubernetes/release#2307

/hold
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2022
@cpanato cpanato mentioned this pull request Mar 19, 2022
Closed
45 tasks
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Mar 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from Verolop and xmudrii March 19, 2022 16:35
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
justaugustus
justaugustus approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but note that we don't really need to promote the releng-ci images.
We intentionally use latest-gox.y tags in CI as something of a canary for other jobs: https://cs.k8s.io/?q=releng-ci&i=nope&files=&excludeFiles=&repos=kubernetes/test-infra

(This is only possible by preferring the staging images over promoted ones.)

@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Mar 21, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 99ee953 into kubernetes:main Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 21, 2022
@cpanato cpanato deleted the promote-releng-ci branch March 21, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Verolop Verolop Awaiting requested review from Verolop

@xmudrii xmudrii Awaiting requested review from xmudrii

2 more reviewers

@justaugustus justaugustus justaugustus approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@puerco puerco

@palnabarun palnabarun

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

8 participants

@cpanato @justaugustus @k8s-ci-robot @saschagrunert @Verolop @puerco @palnabarun @xmudrii