Skip to content

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Oct 14, 2025

/triage accepted
/kind cleanup
/priority backlog
/cc @strongjz @cpanato @tao12345666333
/hold

@k8s-ci-robot k8s-ci-robot requested a review from cpanato October 14, 2025 04:58
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2025
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 39430d7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/68edd86148aea3000894ada5

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2025
@Gacko
Copy link
Member Author

Gacko commented Oct 14, 2025

@cpanato Sadly only approving isn't enough, you also need to /lgtm in this project. 😬

@Gacko
Copy link
Member Author

Gacko commented Oct 14, 2025

And while at it, could you please also review these:

@cpanato
Copy link
Member

cpanato commented Oct 14, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko
Copy link
Member Author

Gacko commented Oct 14, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit cf998c7 into kubernetes:main Oct 14, 2025
46 checks passed
@Gacko Gacko deleted the lowtr branch October 14, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants