Chart: Add volumes for webhook patch job. #13811

ababu13 · 2025-08-22T02:19:20Z

What this PR does / why we need it:

This PR adds support for specifying custom volumes and volumeMounts in the AdmissionWebhook createSecretJob and patchWebhookJob. The template provides the attribute automountServiceAccountToken. However, if automountServiceAccountToken is set to false, the jobs fail. Therefore, to fix that issue, volumeMount and volume needs to be set.

This provides flexibility for users who need to mount additional data (e.g., certificates, configuration files, or shared volumes) into the admission webhook jobs.
Previously, these jobs did not support custom volumes or mounts, which limited use cases where external data is required during webhook secret creation or patching.

Types of changes

New feature (non-breaking change which adds functionality)

Which issue/s this PR fixes

fixes #13810

How Has This Been Tested?

Deployed Helm chart with custom volumes and volumeMounts defined in values.yaml.
Verified that both createSecretJob and patchWebhookJob rendered correctly with the custom mounts in the Job manifests.
Confirmed Jobs executed successfully with the mounted volumes present in the containers.
Verified that no changes occur when values are left as defaults ([]).
Tested the scenario in a dev cluster manually

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added unit and/or e2e tests to cover my changes.
All new and existing tests passed.

netlify · 2025-08-22T02:19:26Z

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	`78595e9`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/68ad681beb616c0008f7eacd

linux-foundation-easycla · 2025-08-22T02:19:26Z

The committers listed above are authorized under a signed CLA.

✅ login: ababu13 / name: Arjun Babu (78595e9)

k8s-ci-robot · 2025-08-22T02:19:29Z

Welcome @ababu13!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-08-22T02:19:29Z

Hi @ababu13. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml

charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml

charts/ingress-nginx/values.yaml

Gacko

Please also implement unit tests in the tests directory of the chart.

charts/ingress-nginx/values.yaml

charts/ingress-nginx/README.md

ababu13 · 2025-08-25T04:21:00Z

Please also implement unit tests in the tests directory of the chart.

@Gacko - Could you please review and approve?

Gacko

/triage accepted
/kind feature
/priority backlog
/ok-to-test
/hold
Gonna fix some nits later, but basically looks good to me.

ababu13 · 2025-08-25T15:12:25Z

@Gacko - Thanks for reviewing! Anything else I need to do from my end?

Gacko · 2025-08-25T18:43:30Z

Please rest assured: I'm having this PR on my list, I will not forget about it. You do not need to continuously request my review.

Gacko

/triage accepted
/kind feature
/priority backlog
/lgtm
/unhold

k8s-ci-robot · 2025-08-26T07:56:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ababu13, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Gacko · 2025-08-26T08:20:46Z

/hold

Gacko · 2025-08-26T08:40:44Z

/unhold

ababu13 · 2025-08-26T15:05:25Z

Thank you very much! - @Gacko

k8s-ci-robot requested review from Gacko and cpanato August 22, 2025 02:19

k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/helm Issues or PRs related to helm charts cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2025

k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2025

Gacko requested changes Aug 22, 2025

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2025

ababu13 requested a review from Gacko August 22, 2025 18:13

ababu13 mentioned this pull request Aug 23, 2025

Add volumeMounts and volumes for createSecretJob and patchWebhookJob #13810

Closed

Gacko changed the title ~~Add volumeMounts and volumes for createSecretJob and patchWebhookJob~~ Chart: Add volumes for webhook patch job. Aug 23, 2025

Gacko requested changes Aug 23, 2025

View reviewed changes

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2025

ababu13 requested a review from Gacko August 24, 2025 20:06

Gacko reviewed Aug 25, 2025

View reviewed changes

k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Aug 25, 2025

ababu13 requested a review from Gacko August 25, 2025 17:28

Chart: Add volumes for webhook patch job.

78595e9

Gacko force-pushed the main branch from 6fcbc23 to 78595e9 Compare August 26, 2025 07:54

Gacko approved these changes Aug 26, 2025

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025

k8s-ci-robot assigned Gacko Aug 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025

k8s-ci-robot merged commit 203b97a into kubernetes:main Aug 26, 2025
28 checks passed

Chart: Add volumes for webhook patch job. #13811

Chart: Add volumes for webhook patch job. #13811

Uh oh!

Conversation

ababu13 commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

Uh oh!

netlify bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Uh oh!

linux-foundation-easycla bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 22, 2025

Uh oh!

k8s-ci-robot commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gacko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ababu13 commented Aug 25, 2025

Uh oh!

Gacko left a comment

Choose a reason for hiding this comment

Uh oh!

ababu13 commented Aug 25, 2025

Uh oh!

Gacko commented Aug 25, 2025

Uh oh!

Gacko left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 26, 2025

Uh oh!

Gacko commented Aug 26, 2025

Uh oh!

Gacko commented Aug 26, 2025

Uh oh!

Uh oh!

ababu13 commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ababu13 commented Aug 22, 2025 •

edited

Loading

netlify bot commented Aug 22, 2025 •

edited

Loading

linux-foundation-easycla bot commented Aug 22, 2025 •

edited

Loading