Skip to content

NGINX: Disable mimalloc's architecture specific optimizations. #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 23, 2025
Merged

NGINX: Disable mimalloc's architecture specific optimizations. #13669

k8s-ci-robot merged 1 commit into from
Jul 23, 2025

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Jul 23, 2025

/triage accepted
/kind bug
/priority backlog

Fixed #13608.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2025
@netlify
Copy link

netlify bot commented Jul 23, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 37cd89f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/6880cf49ba40c10008ca408d

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2025
@Gacko
Copy link
Member Author

Gacko commented Jul 23, 2025

/cherry-pick release-1.13

@Gacko
Copy link
Member Author

Gacko commented Jul 23, 2025

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jul 23, 2025

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jul 23, 2025

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko Gacko added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@Gacko
Copy link
Member Author

Gacko commented Jul 23, 2025

@LarssonOliver I know, you're not a reviewer, but I'd appreciate you giving this a review. 🙂

@k8s-ci-robot k8s-ci-robot merged commit 19d2bd8 into kubernetes:main Jul 23, 2025
39 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jul 23, 2025

@Gacko: new pull request created: #13670

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 23, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jul 23, 2025

@Gacko: new pull request created: #13671

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 23, 2025
Merged
LarssonOliver
LarssonOliver reviewed Jul 23, 2025
View reviewed changes
Copy link

@LarssonOliver LarssonOliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Thanks for the helpful and smooth process!

@Gacko Gacko deleted the vrhkn branch July 23, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

1 more reviewer

@LarssonOliver LarssonOliver LarssonOliver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ingress-nginx pod crashes due to illegal instruction on arm64 version 1.13.0 (helm 4.13.0)

4 participants

@Gacko @k8s-ci-robot @k8s-infra-cherrypick-robot @LarssonOliver