Skip to content

KEP-4828: flagz endpoint with versioned structured response#5550

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
yongruilin:flagz-structure
Oct 15, 2025
Merged

KEP-4828: flagz endpoint with versioned structured response#5550
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
yongruilin:flagz-structure

Conversation

@yongruilin
Copy link
Copy Markdown
Contributor

  • One-line PR description:
    This PR adds Beta criteria of flagz with versioned structured response.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2025
@yongruilin
Copy link
Copy Markdown
Contributor Author

/assign @richabanker
/cc @liggitt

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2025
Comment thread keps/sig-instrumentation/4828-component-flagz/README.md Outdated
@richabanker
Copy link
Copy Markdown
Contributor

/lgtm

cc @dgrisonnet to also take a look. Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 14, 2025

API shape lgtm (one godoc suggestion)

@liggitt liggitt moved this to API review completed, 1.35 in API Reviews Oct 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@dgrisonnet
Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, yongruilin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit ab8b57b into kubernetes:master Oct 15, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 15, 2025
@richabanker richabanker mentioned this pull request Nov 6, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: API review completed, 1.35

Development

Successfully merging this pull request may close these issues.

5 participants