Skip to content

KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements#5409

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
roycaihw:psi-condition-updates
Jun 20, 2025
Merged

KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements#5409
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
roycaihw:psi-condition-updates

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented Jun 11, 2025 •
edited
Loading

  • One-line PR description: Split the two phases into two KEPs to allow them moving at different paces. This original KEP (4205) will keep tracking the implemented exposure of PSI metrics. See KEP-5394: PSI-based node conditions #5395 for more details. Also update Alpha and Beta requirements.

/sig node
/cc @haircommander @ndixita @tiraboschi

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ndixita June 11, 2025 22:10
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 11, 2025

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: tiraboschi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

  • One-line PR description: Split the two phases into two KEPs to allow them moving at different paces. See KEP-5394: PSI-based node conditions #5395 for more details. Also update Alpha and Beta requirements. Make CPU PSI a Beta requirement

/sig node
/cc @haircommander @ndixita @tiraboschi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2025
This was referenced Jun 11, 2025
Closed
Closed
@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Jun 11, 2025

/retitle KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements

@k8s-ci-robot k8s-ci-robot changed the title 4205: Split the two phases into two KEPs and update Alpha and Beta requirements KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements Jun 11, 2025
@roycaihw roycaihw force-pushed the psi-condition-updates branch 2 times, most recently from b399df8 to 1757134 Compare June 17, 2025 00:23
This was referenced Jun 17, 2025
Open
Merged
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jun 17, 2025

@haircommander I've updated the two KEPs as suggested. PTAL

haircommander
haircommander reviewed Jun 17, 2025
View reviewed changes
Comment thread keps/sig-node/4205-psi-metric/README.md
@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Jun 17, 2025

one note but generally this LGTM

kannon92
kannon92 reviewed Jun 17, 2025
View reviewed changes
Comment thread keps/prod-readiness/sig-node/4205.yaml
kannon92
kannon92 reviewed Jun 17, 2025
View reviewed changes
Comment thread keps/sig-node/4205-psi-metric/README.md
@kannon92
Copy link
Copy Markdown
Contributor

kannon92 commented Jun 17, 2025

PRR shadow:

deads2k
deads2k reviewed Jun 18, 2025
View reviewed changes
Comment thread keps/sig-node/4205-psi-metric/README.md
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jun 18, 2025

PRR lgtm.

/approve

haircommander
haircommander reviewed Jun 18, 2025
View reviewed changes
Comment thread keps/sig-node/4205-psi-metric/kep.yaml
# List the feature gate name and the components for which it must be enabled
feature-gates:
- name: PSINodeCondition
- name: KubeletPSI
Copy link
Copy Markdown
Contributor

@haircommander haircommander Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity: this was already done for alpha, we're not changing the feature gate name

@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Jun 18, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
mrunalp
mrunalp reviewed Jun 18, 2025
View reviewed changes
Comment thread keps/sig-node/4205-psi-metric/README.md
@roycaihw
Update the KEP with Beta requirements
ec090f0 
Also update the KEP to reflect the Alpha implementation details
@roycaihw roycaihw force-pushed the psi-condition-updates branch from 7135412 to ec090f0 Compare June 18, 2025 23:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@haircommander haircommander mentioned this pull request Jun 20, 2025
Merged
@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Jun 20, 2025

I took over the last comment https://github.com/kubernetes/enhancements/pull/5409/files#r2155728798 in #5427 , which leaves nothing outstanding here

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mrunalp, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 00ee49a into kubernetes:master Jun 20, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 20, 2025
k8s-ci-robot added a commit that referenced this pull request Jun 20, 2025
@k8s-ci-robot
Merge pull request #5427 from haircommander/psi-perf
69ffb96 
KEP-4205: add blurb about PSI performance on top of #5409
@roycaihw roycaihw mentioned this pull request Jun 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 kannon92 left review comments

@deads2k deads2k deads2k left review comments

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp mrunalp approved these changes

@ndixita ndixita Awaiting requested review from ndixita

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@roycaihw @k8s-ci-robot @lmktfy @haircommander @kannon92 @deads2k @mrunalp