KEP-5394: PSI-based node conditions#5395
Merged
k8s-ci-robot merged 5 commits intokubernetes:masterfrom Jun 19, 2025
Merged
Conversation
k8s-ci-robot
added
sig/node
This was referenced Jun 10, 2025
Member
|
/retitle KEP-5394: Split exposing PSI metrics into its own KEP and add Beta requirements |
k8s-ci-robot
changed the title
roycaihw
force-pushed
the
psi-metrics-kep
branch
2 times, most recently
from
f9c4535 to
e431356
Compare
We are splitting the Phase 2 into its own KEP here, to allow the two Phases to move at different paces. We plan to graduate Phase 1 into Beta, while Phase 2 is still being developed and stay in Alpha.
roycaihw
force-pushed
the
psi-metrics-kep
branch
from
e431356 to
4b0319b
Compare
roycaihw
changed the title
roycaihw
force-pushed
the
psi-metrics-kep
branch
from
4b0319b to
3dd6372
Compare
soltysh
reviewed
Jun 18, 2025
soltysh
reviewed
Jun 18, 2025
soltysh
approved these changes
Jun 19, 2025
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Minor nit, non-blocking alpha, but please make sure to get it added there
/approve
the PRR section
| - Impact of its outage on the feature: | ||
| - Impact of its degraded performance or high-error rates on the feature: | ||
| --> | ||
| N/A |
Contributor
There was a problem hiding this comment.
Since you do actually rely on specific versions of runc, even though k8s uses those by default, I still think it's reasonable to have them explicitly listed. Just in case when someone decided so use non-standard configuration.
mrunalp
approved these changes
Jun 19, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, roycaihw, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/sig node
/cc @haircommander @ndixita @tiraboschi