Skip to content

KEP-4033: bump to beta#4682

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
haircommander:cgroup-cri-beta
Jun 11, 2024
Merged

KEP-4033: bump to beta#4682
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
haircommander:cgroup-cri-beta

Conversation

@haircommander
Copy link
Copy Markdown
Contributor

  • One-line PR description:
    bump KEP-4033 to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
Copy link
Copy Markdown
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
alpha: "v1.28"
beta: "v1.yy"
beta: "v1.30"
stable: "v1.zz"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stable: "v1.zz"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# The following PRR answers are required at beta release
metrics: []

If that's correct, consider updating the comment to clarify.

milestone:
alpha: "v1.28"
beta: "v1.yy"
beta: "v1.30"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.30? Is that right?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2024
Signed-off-by: Peter Hunt <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request Jun 5, 2024
13 tasks
@ffromani
Copy link
Copy Markdown
Contributor

ffromani commented Jun 5, 2024

LGTM (non binding because...)
do we need PRR updates for beta?

@haircommander
Copy link
Copy Markdown
Contributor Author

LGTM (non binding because...) do we need PRR updates for beta?

AFAICT it's all done already

@ffromani
Copy link
Copy Markdown
Contributor

ffromani commented Jun 5, 2024

/lgtm

LGTM (non binding because...) do we need PRR updates for beta?

AFAICT it's all done already

got it, thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2024
@johnbelamaric
Copy link
Copy Markdown
Member

/approve for PRR
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, johnbelamaric, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c3a40a into kubernetes:master Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

6 participants