Skip to content

KEP-2837: Introducing Pod level resource specifications with criteria for alpha phase#4678

Merged
k8s-ci-robot merged 9 commits intokubernetes:masterfrom
ndixita:master
Oct 9, 2024
Merged

KEP-2837: Introducing Pod level resource specifications with criteria for alpha phase#4678
k8s-ci-robot merged 9 commits intokubernetes:masterfrom
ndixita:master

Conversation

@ndixita
Copy link
Copy Markdown
Contributor

@ndixita ndixita commented May 31, 2024 •
edited
Loading

  • One-line PR description: KEP 2837 focuses on initial design to support pod level resources specification in alpha in 1.32

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 May 31, 2024 18:10
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp May 31, 2024 18:10
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2024
mrunalp
mrunalp reviewed May 31, 2024
View reviewed changes
Comment thread keps/sig-node/1592-pod-level-resource-spec/README.md Outdated
mrunalp
mrunalp reviewed May 31, 2024
View reviewed changes
Comment thread keps/sig-node/1592-pod-level-resource-spec/README.md Outdated
@ndixita ndixita force-pushed the master branch 12 times, most recently from 217b643 to 5376ed4 Compare June 1, 2024 01:42
@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Jun 1, 2024

/assign @thockin

@ndixita ndixita force-pushed the master branch 2 times, most recently from 94948ac to 8224bed Compare June 3, 2024 17:42
@ndixita ndixita marked this pull request as ready for review June 3, 2024 17:58
@ndixita
KEP-2837: Introducing Pod level resource specifications KEP
801104d 
Testing image rendering issue in PR precview

Testing image rendering issue in PR precview

Testing image rendering issue in PR precview

Images cache refresh

PRR updates

PRR updates

TOC updates

Upgrade/Downgrade & version skew strategy

Adding more details to user stories and risks and mitigations

Updating toc

Adding white background to images

indentation fixes

indentation fixes

Adding details about CA and ephemeral containers

Fixing typos
thockin
thockin reviewed Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, Better to get a heuristic in than miss the boat.

Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Oct 8, 2024

Quick reminder that there are open comments in the PRR section that will need to be addressed before this can be merged.

@marquiz marquiz mentioned this pull request Oct 8, 2024
Open
alculquicondor
alculquicondor reviewed Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any concerns from the scheduling perspective, so:
/approve
from SIG Scheduling

Comment thread keps/sig-node/2837-pod-level-resource-spec/kep.yaml
@thockin
Copy link
Copy Markdown
Member

thockin commented Oct 8, 2024

/approve

... for API

/lgtm

... for KEP overall

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 8, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 8, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 8, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md Outdated
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 8, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
jpbetz
jpbetz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For PRR

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dchen1107, jpbetz, ndixita, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Oct 9, 2024

/lgtm

As a SIG-Node KEP reviewer

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
* Documentation mentioning high level design.


#### Phase 2: Beta (target 1.32)
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so things like cpu manager, limit ranger, etc. are not part of beta graduation criteria? Or those are in alpha?

Copy link
Copy Markdown
Contributor Author

@ndixita ndixita Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for all features that are scoped out of alpha phase in the KEP design includes CPU manager.

There's a section for Limit Ranger in alpha.

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 9, 2024
View reviewed changes
Comment thread keps/sig-node/2837-pod-level-resource-spec/README.md
@ndixita ndixita mentioned this pull request Oct 9, 2024
Merged
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Nov 27, 2024
Merged
@ndixita ndixita mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 dchen1107 left review comments

@adrianmoisey adrianmoisey adrianmoisey left review comments

@thockin thockin thockin left review comments

@mrunalp mrunalp mrunalp left review comments

@haircommander haircommander haircommander left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@tallclair tallclair tallclair left review comments

@jpbetz jpbetz jpbetz approved these changes

+5 more reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@yujuhong yujuhong yujuhong left review comments

@kerthcet kerthcet kerthcet left review comments

@iholder101 iholder101 iholder101 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

@thockin thockin

@dchen1107 dchen1107

@haircommander haircommander

@yujuhong yujuhong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.