Skip to content

KEP-4205: updating the milestone for alpha to 1.30#4454

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ndixita:master
Feb 3, 2024
Merged

KEP-4205: updating the milestone for alpha to 1.30#4454
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ndixita:master

Conversation

@ndixita
Copy link
Copy Markdown
Contributor

@ndixita ndixita commented Jan 29, 2024 •
edited
Loading

  • One-line PR description: This KEP lays the initial foundations to use PSI metrics for setting Node Conditions.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2024
@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Jan 29, 2024 •
edited
Loading

/milestone v1.30

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 29, 2024

@ndixita: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

Details

In response to this:

/milestone 1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ndixita ndixita force-pushed the master branch 2 times, most recently from 4c08512 to 4907f0f Compare January 29, 2024 18:44
@kannon92
Copy link
Copy Markdown
Contributor

kannon92 commented Jan 30, 2024

Should this be updated also?

https://github.com/kubernetes/enhancements/blob/4907f0fe78a99d89d09f60322a2504e1f89f44e0/keps/sig-node/4205-psi-metric/README.md#does-enabling-the-feature-change-any-default-behavior

So are we able to implement this in 1.30 or are we waiting for a runc change? It may be worth calling that out somewhere (maybe in the KEP issue?)

@ndixita
Copy link
Copy Markdown
Contributor Author

ndixita commented Jan 30, 2024

Should this be updated also?

https://github.com/kubernetes/enhancements/blob/4907f0fe78a99d89d09f60322a2504e1f89f44e0/keps/sig-node/4205-psi-metric/README.md#does-enabling-the-feature-change-any-default-behavior

So are we able to implement this in 1.30 or are we waiting for a runc change? It may be worth calling that out somewhere (maybe in the KEP issue?)

Done! Added the details in the question related to dependencies.

@kannon92
Copy link
Copy Markdown
Contributor

kannon92 commented Feb 1, 2024

thank you @ndixita! Looking forward to this one!

/lgtm
/assign @mrunalp @dchen1107 @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
mrunalp
mrunalp approved these changes Feb 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, ndixita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit f87ea25 into kubernetes:master Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 3, 2024
@pacoxu pacoxu mentioned this pull request Jul 15, 2024
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@mrunalp mrunalp

@kannon92 kannon92

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

7 participants

@ndixita @k8s-ci-robot @kannon92 @mrunalp @dchen1107 @SergeyKanzhelev @bart0sh