Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeClass Scheduling #894

Closed
tallclair opened this issue Mar 14, 2019 · 31 comments
Closed

RuntimeClass Scheduling #894

tallclair opened this issue Mar 14, 2019 · 31 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@tallclair
Copy link
Member

tallclair commented Mar 14, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 14, 2019
@tallclair
Copy link
Member Author

/sig node
/milestone v1.15
/assign

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Mar 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 14, 2019
@tallclair
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 14, 2019
@Huang-Wei
Copy link
Member

@tallclair Does /assign means you'd like to cover the implementation?

@yastij
Copy link
Member

yastij commented Mar 14, 2019

@Huang-Wei - I was planning to work on this, as per discussion with @tallclair and kubernetes/kubernetes#72413

@Huang-Wei
Copy link
Member

Cool, I recalled you mentioned that.

@kacole2 kacole2 added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Apr 11, 2019
@kacole2
Copy link

kacole2 commented Apr 11, 2019

@tallclair i'm going to add this to the tracking sheet for Kubernetes 1.15. I've updated your OP with a direct link to the KEP as well. As usual, please add links to all k/k PRs in this issue so code can be tracked properly. Thanks!

@yastij
Copy link
Member

yastij commented Apr 11, 2019

ref kubernetes/kubernetes#75744

@tallclair tallclair mentioned this issue Apr 12, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 12, 2019
@tallclair tallclair added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 1, 2019
@daminisatya
Copy link

Hey, @tallclair I'm the v1.15 docs release shadow.

I see that you are targeting this enhancement for the 1.15 release. Does this require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@tallclair
Copy link
Member Author

Yes, I will open a doc update (addition to the runtime class page), assuming this makes the cut.

@daminisatya
Copy link

Thank you @tallclair

Please do share the link to the draft docs PR over here or ref to this issue so that I can track it.

@mrbobbytables
Copy link
Member

Hi @tallclair . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@makoscafee
Copy link

Hi, @yastij I am docs Lead here!
Will this enhancement need docs?

@kacole2
Copy link

kacole2 commented Jun 4, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone Jun 4, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 4, 2019
@kacole2
Copy link

kacole2 commented Jul 9, 2019

Hi @yastij @tallclair , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@tallclair
Copy link
Member Author

The plan is to add this to 1.16, but tie it's status to RuntimeClass. In other words, reuse the runtimeclass feature gate, and make it beta.

@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jul 10, 2019
@mrbobbytables mrbobbytables added this to the v1.16 milestone Jul 10, 2019
@daminisatya
Copy link

@yastij @tallclair

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@daminisatya
Copy link

Any update on docs?

@tallclair
Copy link
Member Author

Yeah, this should have a docs update. I'll send a PR next week.

@tallclair
Copy link
Member Author

Docs PR: kubernetes/website#15989

@kacole2
Copy link

kacole2 commented Aug 26, 2019

@tallclair code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Beta?

@tallclair
Copy link
Member Author

Yes, see kubernetes/kubernetes#81016

@draveness
Copy link
Contributor

All the PRs related to RuntimeClass Scheduling except the doc kubernetes/kubernetes#81016 have already been merged into the master branch.

@draveness
Copy link
Contributor

All the PRs required in the beta release have been merged. 🎉

@mrbobbytables
Copy link
Member

Hey there @draveness @tallclair @yastij -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Sep 22, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 22, 2019
@tallclair
Copy link
Member Author

I don't have any runtimeclass scheduling changes planned for v1.17. I would like to let feature soak for another release before graduating to GA.

Note that this is tied to the RuntimeClass feature, and will graduate with it (maybe in v1.18).

@mrbobbytables
Copy link
Member

Noted -- thanks for the update!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2019
@draveness
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2019
@kikisdeliveryservice
Copy link
Member

Hey there @tallclair -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha|beta|stable in 1.18?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

@tallclair
Copy link
Member Author

The lifecycle for this feature should now be tied to RuntimeClass (#585), and no longer needs to be tracked separately.

/close

@k8s-ci-robot
Copy link
Contributor

@tallclair: Closing this issue.

In response to this:

The lifecycle for this feature should now be tied to RuntimeClass (#585), and no longer needs to be tracked separately.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests