Keep pipeline job and comment consistent #111
Conversation
In Kubernetes/OpenStack integration scenario, we should keep pipeline name, job name and trigger comment consistence, that build consist user experience for developer from k8s community, and easy to understand how to trigger the specific jobs when the job failed. - update all of pipeline name, job name and trigger comment for k8s jobs - run all of jobs in separate pipeline when PR commit and update, and report to github independently - branch-v1.10.0 should be just branch-v1.10 Fixes theopenlab/openlab#46
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/S
|
Hi @dims , the current master .zuul.yaml refer to a pipeline cloud-provider-openstack-all, we have removed it in OpenLab side, see theopenlab/project-config#18 , we disable the trigger of cloud-proivder-openstack in OpenLab side so that zuul can launch normally (if some project use the deleted pipeline, that block zuul to start ), so the PR do not trigger OpenLab CI, let us merge the PR, then retest it in a clean PR |
|
@kiwik the jobs in the periodic pipeline ... do they need unique names as well? so they don't get into the same bucket/directory as the jobs that run against PR(s)? |
|
@dims I am not sure your point, the test log will be put into different sub-directory with timestamp of specific bucket when we execute upload_e2e.py to upload it, so even if we upload same log file twice, it also be in different directory. Or you mean that we should put the logs that's outputted by periodic jobs and PR trigger jobs into different top-directory, this is you want? ├── bucket
│ ├── periodic jobs
│ │ ├── xxxx
│ │ ├── yyyy
│ ├── trigger jobs
│ │ ├── zzzz
│ │ ├── aaaa |
|
hi @dims , I prepare to submit a PR in kube-infra to config testgrid bucket, please check the code https://github.com/theopenlab/test-infra/blob/conformance-cloud-provider-openstack/testgrid/config.yaml#L2514-L2524 , that's bucket structure you want? |
- cloud-provider-openstack-acceptance-test-k8s-cinder - cloud-provider-openstack-acceptance-test-standalone-cinder - cloud-provider-openstack-acceptance-test-csi-cinder
k8s-ci-robot
added
size/M
|
@kiwik |
|
@kiwik can we please use please compare with what is used for the local-e2e jobs (from https://k8s-testgrid.appspot.com/sig-testing-misc) https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-local-e2e/896 |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Keep pipeline job and comment consistent
3 participants
What this PR does / why we need it:
In Kubernetes/OpenStack integration scenario, we should keep pipeline
name, job name and trigger comment consistence, that build consist user
experience for developer from k8s community, and easy to understand how
to trigger the specific jobs when the job failed.
report to github independently
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes theopenlab/openlab#46Special notes for your reviewer:
@dims
Release note: