Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Exec & Attach APIs #45

Closed
ianlewis opened this issue Nov 22, 2016 · 13 comments
Closed

Support for Exec & Attach APIs #45

ianlewis opened this issue Nov 22, 2016 · 13 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ianlewis
Copy link

Currently the client doesn't seem to support the Exec into container, attach to container APIs. The client should support those APIs.

@JrCs
Copy link

JrCs commented Dec 16, 2016

Yes its will be great to support exec and attach to container from the client-go.
I really need it.

@lavalamp
Copy link
Member

lavalamp commented Jan 3, 2017

I agree, we should support these.

@rmohr
Copy link
Contributor

rmohr commented May 15, 2017

Until the work on this ticket is done, it is pretty simple to use ther rest.Config to create your own exec call. I created a simple example. A detailed description is also available.

@JrCs
Copy link

JrCs commented May 22, 2017

@rmohr thanks for the simple example.
The only problem with your example is that you can't detect if the command return with a non zero exit code.

@topherbullock
Copy link

I need this enough to pick it up and work on a PR.

Seems like kubectl would also benefit from this

Going to make an effort at adding client support for an Exec() method (not sure where it should live) which allows different Executors, and has a default one like this.

Thoughts? Suggestions? Cryptic warnings?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 31, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@geekodour
Copy link

What's the update on this?

@LeoLiuYan
Copy link

LeoLiuYan commented Aug 28, 2019

So should we reopen this issue?

@geekodour
Copy link

I'll be happy to work on this, If provided some initial pointers. The current way to do this seems to be using websockets only. right?

@LeoLiuYan
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@LeoLiuYan: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

9 participants