Split Kubermatic alerts into master and seed #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-none
|
LGTM label has been added. Git tree hash: 761f76b0c52019ee679e92cd9c18c2825fb85457
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
alvaroaleman
pushed a commit
that referenced
this pull request
Mar 4, 2019
* split kubermatic alerts into master and seed * rebuild outdated alerting rules
kubermatic-bot
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Use downstream triple package Upstream removed the triple package[0], in order to be able to upgrade client-go we need to have a downsream version. [0] kubernetes/kubernetes#70966 * WIP * Update fixtures * Override cluster-api dependency * Fix linting * Split Kubermatic alerts into master and seed (#2909) * split kubermatic alerts into master and seed * rebuild outdated alerting rules * Remove clusterv1alpha1 clientset dependecy from cluster controller * Remove unused script * Use ctrlruntimeClient in pkg/handler/node_v1.go * Finish moving handler to ctrlruntimeClient * Remove GetAdminKubernetesClientForCustomerCluster from Clusterprovider * Use dynamic client for machines in conformance tester * Fix handler tests * Remove unused script * Fix linting * Actually fix linting error * Register schemes * Register clusterapi scheme in usercluster connection provider * Remove redundant options to the dynamic client * Filter list calls * Put impersonated users into system:authenticated group This is required for some very basic things like API discovery to work * Dep ensure * Add permissions to get nodes * Rbac generator script: Use a different metrics serving port than cluster controller * Fixup rbac for usercluster nodes * Dont fatalf outside of main * Print reconciling info on level four
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Kubermatic chart now allows to not deploy master components, so we need to make sure that there are no false positive alerts being fired all the time.
Existing installations will continue to work because their
kubermatic-*.yamlexpression in the values.yaml will match both new alert YAML files.Which issue(s) this PR fixes:
Fixes #2861
Release note: