Repository navigation
Conversation
The "Viewing Logs" example in the local execution overview passes
node_index= to TrainerClient.get_job_logs(). That method has no
node_index parameter; its signature is (name, step="node-0",
follow=False), so copying the example raises:
TypeError: TrainerClient.get_job_logs() got an unexpected keyword
argument 'node_index'
Drop node_index=0 from the first call, since node-0 is the default
step, and pass step=f"node-{node_index}" in the per-node loop, as
docs/user-guides/pytorch.md already does.
Assisted-by: Claude <[email protected]>
Signed-off-by: YoungjuKim <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The "Viewing Logs" example in
docs/user-guides/local-execution/overview.mdcallsclient.get_job_logs(job_name, node_index=0, follow=True).TrainerClient.get_job_logs()has nonode_indexparameter; its signature is(name, step="node-0", follow=False). Withkubeflow==0.5.0(the latest release on PyPI) the example fails:This PR drops
node_index=0from the first call (the default step isnode-0) and usesstep=f"node-{node_index}"in the per-node loop, asdocs/user-guides/pytorch.mdalready does.Local checks (Docker,
python:3.12-slim, master a5ea455):python -m sphinx -W --keep-going -b html . _build/htmlindocs/withdocs/requirements.txt:build succeeded., no warnings.kubeflow==0.5.0installed, binding the documented arguments toinspect.signature(TrainerClient.get_job_logs): the oldnode_index=0, follow=Trueandnode_index=1calls raiseTypeError: got an unexpected keyword argument 'node_index'; the newfollow=Trueandstep="node-1"calls bind. No TrainJob was run with the local backends for this change.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):None. No existing issue or pull request for this was found.
Checklist:
Prepared with help from Claude (AI), including the local checks described above.