Skip to content

fix(ci): Fix new contributors GH actions workflow lint errors#3024

Merged
andreyvelich merged 1 commit into
kubeflow:masterfrom
astefanutti:pr-45
Dec 9, 2025
Merged

fix(ci): Fix new contributors GH actions workflow lint errors#3024
andreyvelich merged 1 commit into
kubeflow:masterfrom
astefanutti:pr-45

Conversation

@astefanutti

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

CI fails because of lint errors after #3016.

Checklist:

  • Docs included if any changes are user facing

@astefanutti astefanutti changed the title fix(ci): Fix new contributors GH actions worflow lint errors fix(ci): Fix new contributors GH actions workflow lint errors Dec 8, 2025

@kramaranya kramaranya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@coveralls

coveralls commented Dec 8, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20022826445

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.435%

Totals Coverage Status
Change from base Build 19935327740: 0.0%
Covered Lines: 1237
Relevant Lines: 2405

💛 - Coveralls

@astefanutti

Copy link
Copy Markdown
Contributor Author

Let me approve it so we can rebase the other PRs. The remaining issue is going to be fixed with #3023.

/approve

@astefanutti

Copy link
Copy Markdown
Contributor Author

/assign @kubeflow/kubeflow-trainer-team

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich andreyvelich merged commit ba66ef0 into kubeflow:master Dec 9, 2025
32 of 34 checks passed
@google-oss-prow google-oss-prow Bot added this to the v2.2 milestone Dec 9, 2025
mahdikhashan pushed a commit to mahdikhashan/trainer that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants