fix(ci): Fix kube-api-linter install#3023
Conversation
astefanutti
force-pushed
the
pr-44
branch
2 times, most recently
from
44e5e00 to
68558f7
Compare
Pull Request Test Coverage Report for Build 20024793520Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 20021484572Details
💛 - Coveralls |
Signed-off-by: Antonin Stefanutti <[email protected]>
|
/assign @kubeflow/kubeflow-trainer-team |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks @astefanutti!
/assign @tenzen-y
| t.Trainer.Command = command | ||
| t.Trainer.Args = args | ||
| t.Trainer.ResourcesPerNode = &corev1.ResourceRequirements{ | ||
| t.Image = &image |
There was a problem hiding this comment.
Why we didn't update t.Trainer.NumNodes and t.Trainer.NumProcPerNode ?
There was a problem hiding this comment.
It's not possible because the wrapper overrides NumNodes and NumProcPerNode.
|
@astefanutti Can you fix new line please? |
@andreyvelich I've open #3024 to fix this as it's unrelated. |
Can you just add this commit into this PR, since CI is failing in #3024 due to golangci ? |
It's not really failing because of golangci but because some lint errors introduced when the welcome workflow got merged. That PR fixes an issue with golangci and some latest versions of Git used to compile the kube-api-linter. |
|
Sounds good, let me manually merge: #3024 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Antonin Stefanutti <[email protected]>
4 participants
What this PR does / why we need it:
CI currently fails during golangci-lint execution and the installation of kube-api-linter.
This PR upgrades golangci-lint to the latest version to get golangci/golangci-lint#6205.
Checklist: