[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/test kubeflow-pipeline-mkp-test

/test kubeflow-pipeline-e2e-test

/test kubeflow-pipeline-mkp-test

/test kubeflow-pipeline-upgrade-test

/retest

/test kubeflow-pipeline-e2e-test

@chensun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test failure is due to failed to retrieve the log. And this is due to a bug/breaking change from Argo side: argoproj/argo-workflows#10107 (comment)

Test failure is due to failed to retrieve the log

See also #8935 for an issue on logs in Argo v3.4.

I mentioned there that setting POD_NAMES=v1 will also revert back to the previous naming.

@chensun the current argo is woefully out of date and has not been patched since Nov 2022, and various CVE's have accumulated since then.

What do you think of using the work around as suggested by Terry here, and manually generating the pod name. Can this be something we could do to unblock this upgrade (is there a lot of overhead for this?). Or setting the POD_NAMES=v1 on the workflow controller. I personally think manually generating the name here is better, so we can remain a bit more agnostic to how Argo is being deployed by users.

There seems like there's a PR in transit right now that could resolve this issue for a less hacky fix in a later argo version that we can keep an eye on and create a tracker for.

I think we don't need this PR opened as we have #10568 in progress. @chensun wdyt?

/close

Superseded by #10568

@rimolive: Closed this PR.