Skip to content

docs: update README #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 1 commit into from
Sep 19, 2024
Merged

docs: update README #400

google-oss-prow merged 1 commit into from
Sep 19, 2024

Conversation

@tarilabs
Copy link
Member

@tarilabs tarilabs commented Sep 19, 2024

Description

align diagram about testing architecture
following #326

include FOSSA license scanning badge
following #323

How Has This Been Tested?

n/a

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • [n/a] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@tarilabs
docs: update README
6061c85 
align diagram about testing architecture
following kubeflow#326

include FOSSA license scanning badge
following kubeflow#323

Signed-off-by: Matteo Mortari <[email protected]>
rareddy
rareddy approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 19, 2024
@google-oss-prow
Copy link

google-oss-prow bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 044edd7 into kubeflow:main Sep 19, 2024
@tarilabs tarilabs mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rareddy rareddy rareddy approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ckadner ckadner Awaiting requested review from ckadner

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@rareddy rareddy

Labels

approved Area/Documentation lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarilabs @rareddy