Test Python client against latest MR #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Contributor
Author
|
cc: @tarilabs |
tarilabs
approved these changes
Aug 30, 2024
Member
tarilabs
left a comment
tarilabs
left a comment
There was a problem hiding this comment.
Thank you @isinyaaa , this is awesome so now we have actually an even simpler way to make sure the real rest server is in-place when making e2e tests
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Al-Pragliola
pushed a commit
to Al-Pragliola/model-registry
that referenced
this pull request
Sep 3, 2024
* py: tests: rename basic to REST bindings Signed-off-by: Isabella do Amaral <[email protected]> * py: create e2e test mode Signed-off-by: Isabella do Amaral <[email protected]> --------- Signed-off-by: Isabella do Amaral <[email protected]>
7 tasks
tarilabs
added a commit
to tarilabs/model-registry
that referenced
this pull request
Sep 19, 2024
align diagram about testing architecture following kubeflow#326 include FOSSA license scanning badge following kubeflow#323 Signed-off-by: Matteo Mortari <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
align diagram about testing architecture following #326 include FOSSA license scanning badge following #323 Signed-off-by: Matteo Mortari <[email protected]>
adysenrothman
pushed a commit
to adysenrothman/model-registry
that referenced
this pull request
Sep 16, 2025
[pull] main from kubeflow:main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the majority of Python client tests depend on the current implementation of MR, build it in favor of using the last pushed version.
This also creates a new (e2e) test mode for the Python client to highlight the dependencies.
Description
How Has This Been Tested?
Updated on GHA, ran
make test-e2elocally. Also tested with nox.Merge criteria:
DCOcheck)If you have UI changes