Skip to content

Drop Kubernetes v1.23 and support Kubernetes v1.26 #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 1 commit into from
Jul 31, 2023
Merged

Drop Kubernetes v1.23 and support Kubernetes v1.26 #2177

google-oss-prow merged 1 commit into from
Jul 31, 2023

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 20, 2023

What this PR does / why we need it:
I upgraded the Kubernetes dependencies to v1.26. By this PR, we drop support for the Kubernetes v1.23.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #2155

Checklist:

  • Docs included if any changes are user facing

/assign @andreyvelich @johnugeorge

@tenzen-y tenzen-y force-pushed the upgrade-k8s-v1.26 branch 2 times, most recently from 395f236 to df3f7bb Compare July 20, 2023 18:36
@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 20, 2023

It seems that manusa/actions-setup-minikub doesn't support v1.26.

https://github.com/kubeflow/katib/actions/runs/5614686888/job/15213331797?pr=2177

So, we need to switch a way to set up minikube to https://github.com/medyagh/setup-minikube.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 20, 2023

/hold

@tenzen-y tenzen-y mentioned this pull request Jul 20, 2023
Merged
1 task
@tenzen-y tenzen-y force-pushed the upgrade-k8s-v1.26 branch 3 times, most recently from cd20f43 to d4a3788 Compare July 31, 2023 07:24
@gaocegege
Copy link
Member

gaocegege commented Jul 31, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 31, 2023
@tenzen-y tenzen-y mentioned this pull request Jul 31, 2023
Merged
1 task
@tenzen-y tenzen-y force-pushed the upgrade-k8s-v1.26 branch from d4a3788 to 52a78c0 Compare July 31, 2023 16:47
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 31, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 31, 2023

@andreyvelich I rebased this PR.

andreyvelich
andreyvelich approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 31, 2023
@google-oss-prow
Copy link

google-oss-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 31, 2023 •
edited
Loading

@andreyvelich Could you restart https://github.com/kubeflow/katib/actions/runs/5717370025/job/15490963428?pr=2177 and https://github.com/kubeflow/katib/actions/runs/5717370027/job/15490961883?pr=2177?

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 31, 2023

@andreyvelich Thanks for restarting the job.
Could you restart https://github.com/kubeflow/katib/actions/runs/5717370025/job/15490963428?pr=2177 as well?

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 31, 2023

/hold cancel

@google-oss-prow google-oss-prow bot merged commit d67c07b into kubeflow:master Jul 31, 2023
@tenzen-y tenzen-y deleted the upgrade-k8s-v1.26 branch July 31, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

@anencore94 anencore94 Awaiting requested review from anencore94

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@andreyvelich andreyvelich

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tenzen-y @gaocegege @andreyvelich @johnugeorge