fix mysql version in docker image #1594
Conversation
|
Hi @munagekar. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you for updating this @munagekar!
I think it's very good point, we should keep the particular version for mysql.
/ok-to-test
What do you think @gaocegege @johnugeorge ?
| containers: | ||
| - name: katib-mysql | ||
| image: mysql:8 | ||
| image: mysql:8.0.26 |
There was a problem hiding this comment.
Can we also add imagePullPolicy: Always here to avoid problems with caching data if users are running another mysql instance for other components ?
I remember that we had couple of problems with that.
There was a problem hiding this comment.
imagePullPolicy: Always is not required as long mysql:8.0.26 tag image is not updated in dockerhub, and cache can be used if available.
However, I don't have any strong opinion, I can add it if you feel so.
There was a problem hiding this comment.
Do we have any use-case when mysql team can update previous image tag on the dockerhub ?
There was a problem hiding this comment.
Looking at release history & dockerhub Mysql Team hasn't done it. I think it should be fine without imagePullPolicy:"Always"
A possible usecase would be when Dockerimages such as ubuntu are rebuilt and pushed again to dockerhub when there are security fixes. Mysql doesn't seem to do so either.
Even if there were to be a security fix with mysql docker image. The mysql version would remain the same and this issue would not occur.
[InnoDB] Cannot boot server version 80017 on data directory built by version 80018. Downgrade is not supported
|
/retest Thanks for your contribution! 🎉 👍 LGTM 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, munagekar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
What this PR does / why we need it:
The current image
mysql:8is mutable tag. Every time an update is made this points to a new version. I.e it could point to 8.0.1 or 8.0.2 or 8.0.26. SQL upgrades are one-way it is not possible to downgrade.This leads to errors if the image is already cached on kubernetes node. For example node already has 8.0.2 image cached, but 8.0.26 on was used on another node.
Another possible alternative would be to set image pull policy to Always.