Skip to content

Fix: kubectl wait condition case from ready to Ready - #3076

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
madmecodes:fix-kubectl-condition-case
Mar 27, 2025
Merged

Fix: kubectl wait condition case from ready to Ready#3076
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
madmecodes:fix-kubectl-condition-case

Conversation

@madmecodes

@madmecodes madmecodes commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

✏️ Summary of Changes

Kubernetes API conditions are case-sensitive and standard
pod conditions use capitalized names. This changes all
instances of "--for=condition=ready" to "--for=condition=Ready"
to ensure consistent behavior across installation scripts.

📦 Dependencies

none

🐛 Related Issues

none

✅ Contributor Checklist

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@madmecodes

madmecodes commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

@juliusvonkohout
I was facing an issue with the OAuthProxy component-wise installation. The script wasn't waiting and was exiting immediately because it was using --for=condition=ready instead of --for=condition=Ready. Additionally, since we use --for=condition=Ready in other places, we should maintain consistency.

Screenshot 2025-03-27 at 10 16 01 PM

@madmecodes

madmecodes commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

i dont know, but is this the issue, our dex test were failing in previous PRs, because it wasnt waiting for all the pods to be ready, as Pipeline script used --for-condition=ready and not --for-condition=Ready, not sure about this.

@juliusvonkohout juliusvonkohout self-assigned this Mar 27, 2025
@juliusvonkohout

juliusvonkohout commented Mar 27, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Mar 27, 2025
@google-oss-prow

google-oss-prow Bot commented Mar 27, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit af624af into kubeflow:master Mar 27, 2025
kunal-511 pushed a commit to kunal-511/kubeflow-manifests that referenced this pull request Mar 28, 2025
@madmecodes @kunal-511
Fix: kubectl wait condition case from ready to Ready (kubeflow#3076)
9d364c4 
Signed-off-by: madmecodes <[email protected]>
kunal-511 pushed a commit to kunal-511/kubeflow-manifests that referenced this pull request Mar 28, 2025
@madmecodes @kunal-511
Fix: kubectl wait condition case from ready to Ready (kubeflow#3076)
e627e3c 
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: kunal-511 <[email protected]>
@coderabbitai coderabbitai Bot mentioned this pull request Jun 16, 2026
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout
@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madmecodes @juliusvonkohout